Page MenuHomePhabricator

Conduit "*.search" methods unnecessarily persist search queries
Closed, ResolvedPublic

Description

Currently, invoking a modern *.search Conduit method will unnecessarily generate a saved query as a side effect. We do this when users issue normal queries so they can share URLs and bookmark things, but there's no need to do it for Conduit queries.

This likely primarily affects Phacility production, as we routinely issue large queries via "*.search" methods and have consequently accumulated an impressive amount of data.

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision

Event Timeline

epriestley added a revision: Restricted Differential Revision.Jul 9 2016, 1:50 PM

(Only unique queries are saved, so this should be a small amount of data in most cases, but the Phacility setup tends to mean we issue a lot of unique queries.)

epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jul 10 2016, 3:04 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.