Page MenuHomePhabricator
Feed Advanced Search

Apr 18 2017

gregprice added a comment to T10640: Allow application queries to be promoted as global search modes.

Just in my personal experience, I think it was sometime in the last 6 months that I realized Phabricator has a concept of "application search" and "global search", and that a lot of the searches I'd been doing were the latter and that's why they were so limited in functionality. I'd been using Phabricator for years and always had the sense that search didn't work very well, and that there were different forms I might get for it with different sets of fields, and it was unpredictable which one I'd get; but it wasn't until I became responsible for actually running Phabricator and started paying much closer attention to its concepts that I twigged to that pattern as the explanation for which searches got which form.

Apr 18 2017, 12:33 AM · Search, Feature Request

Apr 13 2017

epriestley added a revision to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Restricted Differential Revision.
Apr 13 2017, 2:20 AM · Search, Customer Impact, Bug Report
epriestley closed T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token as Resolved by committing Restricted Diffusion Commit.
Apr 13 2017, 2:08 AM · Search, Customer Impact, Bug Report
epriestley closed T12003: Explain to users how fulltext queries are parsed and executed as Resolved by committing Restricted Diffusion Commit.
Apr 13 2017, 2:08 AM · Search
epriestley closed T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty as Resolved by committing Restricted Diffusion Commit.
Apr 13 2017, 12:57 AM · Search
epriestley added a comment to T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty.

I'm only like 85% sure that D17667 really fixes things so yell if it still looks ~weird~.

Apr 13 2017, 12:57 AM · Search
chad added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

(◍•ᴗ•◍)

Apr 13 2017, 12:52 AM · Search
alanh added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

\o/

Apr 13 2017, 12:41 AM · Search
epriestley closed T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it as Resolved.

Searching for ひらがな or 漢字汉字 or 漢字汉 now finds this task. Searching for 漢字 or 汉字 does not, but I think that's because they're under the minimum token length.

Apr 13 2017, 12:19 AM · Search
epriestley closed T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it, a subtask of T12003: Explain to users how fulltext queries are parsed and executed, as Resolved.
Apr 13 2017, 12:18 AM · Search
epriestley added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

漢字汉

Apr 13 2017, 12:09 AM · Search
epriestley added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

ひらがな
漢字汉字

Apr 13 2017, 12:08 AM · Search
epriestley added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

漢字
汉字

Apr 13 2017, 12:07 AM · Search
epriestley renamed T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token from Stemming + MySQL Fulltext search can lead to unexpected results to MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token.
Apr 13 2017, 12:05 AM · Search, Customer Impact, Bug Report
epriestley added a revision to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: Restricted Differential Revision.
Apr 13 2017, 12:05 AM · Search
epriestley added a revision to T12003: Explain to users how fulltext queries are parsed and executed: Restricted Differential Revision.
Apr 13 2017, 12:04 AM · Search
epriestley added a revision to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Restricted Differential Revision.
Apr 13 2017, 12:04 AM · Search, Customer Impact, Bug Report

Apr 12 2017

epriestley added a revision to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: Restricted Differential Revision.
Apr 12 2017, 10:44 PM · Search
epriestley added a revision to T12003: Explain to users how fulltext queries are parsed and executed: Restricted Differential Revision.
Apr 12 2017, 10:44 PM · Search
epriestley added a revision to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Restricted Differential Revision.
Apr 12 2017, 10:44 PM · Search, Customer Impact, Bug Report
epriestley added a revision to T7860: When users search for "#x y", treat "#x" as a project hashtag: Restricted Differential Revision.
Apr 12 2017, 10:44 PM · Search
epriestley added a revision to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: Restricted Differential Revision.
Apr 12 2017, 10:43 PM · Search
epriestley added a revision to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Restricted Differential Revision.
Apr 12 2017, 10:43 PM · Search, Customer Impact, Bug Report
epriestley added a revision to T7860: When users search for "#x y", treat "#x" as a project hashtag: Restricted Differential Revision.
Apr 12 2017, 10:43 PM · Search
epriestley added a revision to T12003: Explain to users how fulltext queries are parsed and executed: Restricted Differential Revision.
Apr 12 2017, 10:43 PM · Search
epriestley added a revision to T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty: Restricted Differential Revision.
Apr 12 2017, 9:58 PM · Search
chad added a comment to T8660: Top search bar is not consistent about searching open vs closed document types.

Thanks, much appreciated! 👍🏻

Apr 12 2017, 6:41 PM · FreeBSD, Search, Restricted Project
Taskle added a comment to T8660: Top search bar is not consistent about searching open vs closed document types.

@chad thanks for sharing your perspective - I will try to share positive feedback as well. Hopefully that will allow the constructive feedback I have to be considered, as I have felt like the feedback and ideas I have shared have often been dismissed or had a very harsh response.

Apr 12 2017, 6:15 PM · FreeBSD, Search, Restricted Project
chad added a comment to T8660: Top search bar is not consistent about searching open vs closed document types.

Users can customize their search (like I have below) or you can fork Phabricator to provide a different experience.

Apr 12 2017, 5:45 PM · FreeBSD, Search, Restricted Project
chad added a comment to T8660: Top search bar is not consistent about searching open vs closed document types.

Your feedback is continually negative and tone deaf.

Apr 12 2017, 5:32 PM · FreeBSD, Search, Restricted Project
Taskle added a comment to T8660: Top search bar is not consistent about searching open vs closed document types.

@chad I am trying to give constructive feedback to improve the product, including both the pain points and suggested improvements. I am not used to this kind of response to product feedback. It's unfortunate.

Apr 12 2017, 5:30 PM · FreeBSD, Search, Restricted Project
chad added a comment to T8660: Top search bar is not consistent about searching open vs closed document types.

You've made it quite clear on multiple occasions Phabricator is a painful product to use for everyone at your company.

Apr 12 2017, 5:29 PM · FreeBSD, Search, Restricted Project
Taskle added a comment to T8660: Top search bar is not consistent about searching open vs closed document types.

Our interest / problems related to this persist. I haven't been vocal as I don't know what else to do other than to share my feedback, but I continue to hear negative feedback internally in our company regarding this issue, per the description above.

Apr 12 2017, 5:20 PM · FreeBSD, Search, Restricted Project
epriestley moved T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud) from Backlog to v2 on the Search board.
Apr 12 2017, 4:27 PM
epriestley moved T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token from Backlog to v2 on the Search board.
Apr 12 2017, 4:27 PM · Search, Customer Impact, Bug Report
epriestley added a project to T12137: MySQL fulltext search returns no results in boolean mode when a query includes +"x", where "x" is a stopword or short token: Search.
Apr 12 2017, 4:27 PM · Search, Customer Impact, Bug Report
epriestley added a project to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): Search.
Apr 12 2017, 4:27 PM
epriestley moved T12425: User-initiated search reindex tasks can end up stuck behind import tasks in the daemon queue from Backlog to Future on the Customer Impact board.
Apr 12 2017, 3:11 PM · Customer Impact, Daemons, Search, Diffusion
epriestley edited projects for T12425: User-initiated search reindex tasks can end up stuck behind import tasks in the daemon queue, added: Customer Impact; removed Phacility.
Apr 12 2017, 3:10 PM · Customer Impact, Daemons, Search, Diffusion
epriestley removed a project from T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: Support Impact.
Apr 12 2017, 2:48 PM · Search
epriestley closed T12493: Upgrading: Fulltext Search Services as Resolved.

This has been live for nearly two weeks without anything apparently exploding so we don't have any further acton planned upstream (although see T12450 for some followups). If you do run into issues, feel free to file new tasks describing them.

Apr 12 2017, 2:43 PM · Elasticsearch, Search, Guides
epriestley closed T8660: Top search bar is not consistent about searching open vs closed document types as Wontfix.

This has been open for about two years without a significant amount of additional confusion or interest, so I don't currently plan to change it.

Apr 12 2017, 2:42 PM · FreeBSD, Search, Restricted Project
epriestley merged T12500: Render highlighted search result body snippets in global search results views into T8646: Provide more context for search results, particularly wiki documents.
Apr 12 2017, 2:40 PM · Design, Search, Restricted Project
epriestley merged task T12500: Render highlighted search result body snippets in global search results views into T8646: Provide more context for search results, particularly wiki documents.
Apr 12 2017, 2:40 PM · Elasticsearch, Search, Feature Request
epriestley added a comment to T12500: Render highlighted search result body snippets in global search results views.

I'm just going to merge this into T8646 which broadly discusses richer search results.

Apr 12 2017, 2:40 PM · Elasticsearch, Search, Feature Request
epriestley moved T10315: Make it more clear to users how to rebuild search indexes after adding search support to custom fields from v2 to Future on the Search board.
Apr 12 2017, 2:38 PM · Custom Fields, Search, Documentation
epriestley renamed T7860: When users search for "#x y", treat "#x" as a project hashtag from Project tags can not be found via the fulltext search index to When users search for "#x y", treat "#x" as a project hashtag.
Apr 12 2017, 2:38 PM · Search
epriestley moved T12493: Upgrading: Fulltext Search Services from Backlog to v2 on the Search board.
Apr 12 2017, 2:35 PM · Elasticsearch, Search, Guides
epriestley moved T12500: Render highlighted search result body snippets in global search results views from Backlog to v2 on the Search board.
Apr 12 2017, 2:35 PM · Elasticsearch, Search, Feature Request

Apr 7 2017

chad renamed T12500: Render highlighted search result body snippets in global search results views from Render highlighted search result body snippets in global search results views. to Render highlighted search result body snippets in global search results views.
Apr 7 2017, 6:20 AM · Elasticsearch, Search, Feature Request

Apr 5 2017

epriestley closed T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles), a subtask of T6721: Would like ability to search tasks by title, as Resolved.
Apr 5 2017, 7:54 PM · Search, Maniphest

Apr 4 2017

20after4 added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Apr 4 2017, 5:18 PM · Search
20after4 added a revision to T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty: Restricted Differential Revision.
Apr 4 2017, 5:15 PM · Search
20after4 added 1 mock(s) for T8646: Provide more context for search results, particularly wiki documents: M1474: Show snippets in search results....
Apr 4 2017, 4:40 PM · Design, Search, Restricted Project
20after4 added 1 task(s) for M1474: Show snippets in search results...: T8646: Provide more context for search results, particularly wiki documents.
Apr 4 2017, 4:40 PM · Search
20after4 created M1474: Show snippets in search results....
Apr 4 2017, 4:39 PM · Search
20after4 added a revision to T12500: Render highlighted search result body snippets in global search results views: Restricted Differential Revision.
Apr 4 2017, 2:10 AM · Elasticsearch, Search, Feature Request

Apr 3 2017

20after4 created T12500: Render highlighted search result body snippets in global search results views.
Apr 3 2017, 5:41 PM · Elasticsearch, Search, Feature Request
20after4 added a comment to T7860: When users search for "#x y", treat "#x" as a project hashtag.

I implemented this recently but then pulled it out because ... project slug lookup is a gigantic mess right now.

Apr 3 2017, 3:16 PM · Search

Apr 2 2017

epriestley added a comment to T12450: New Search Configuration Errata.

If you can run bin/whatever, policies no longer matter since you can bin/storage shell or any other number of dangerous things.

Apr 2 2017, 9:56 PM · Search
20after4 added a comment to T12450: New Search Configuration Errata.

Maybe let bin/search commands target a specific service.

Apr 2 2017, 8:56 PM · Search
epriestley added a comment to T12450: New Search Configuration Errata.

PhabricatorEnv::beginScopedEnv(); works anywhere if this makes more sense as, like, bin/search self-test or something rather than a unit test.

Apr 2 2017, 8:52 PM · Search
20after4 added a comment to T12450: New Search Configuration Errata.

It would be nice to build a practical test suite instead, where we put specific documents into the index and then search for them.

Apr 2 2017, 8:49 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 8:08 PM · Search
epriestley added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Apr 2 2017, 8:05 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 7:20 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 7:19 PM · Search
epriestley updated the task description for T12493: Upgrading: Fulltext Search Services.
Apr 2 2017, 7:14 PM · Elasticsearch, Search, Guides
epriestley added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Apr 2 2017, 7:10 PM · Search
epriestley created T12493: Upgrading: Fulltext Search Services.
Apr 2 2017, 6:59 PM · Elasticsearch, Search, Guides
epriestley added a comment to T12450: New Search Configuration Errata.

Oh, I'm wrong. It hasn't been removed without replacement: there's a new path option for Elastic. I think there's probably a bug in indexExists() then, since it looks for 'phabricator' by name:

Apr 2 2017, 6:49 PM · Search
epriestley added a comment to T12450: New Search Configuration Errata.

(This is all wrong, see below.)

Apr 2 2017, 6:42 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 6:29 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 6:19 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 5:06 PM · Search
epriestley added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Apr 2 2017, 5:05 PM · Search
epriestley added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Apr 2 2017, 4:59 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 4:44 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 4:37 PM · Search
epriestley added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Apr 2 2017, 4:33 PM · Search
epriestley added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Apr 2 2017, 4:20 PM · Search
epriestley added a comment to T12450: New Search Configuration Errata.

So I ran into one problem when deploying the latest code to WMF production. We now throw a setup error if we have a cluster with no readable hosts. It actually makes sense to have a cluster that is write-only so that setup error is bogus.

Apr 2 2017, 3:57 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 3:42 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 3:05 PM · Search

Mar 31 2017

epriestley merged T12486: Maniphest Search exclude-by-tag doesn't work consistently with subprojects into T12438: Project tokenizer functions like "any()" and "not()" do not include descendants.
Mar 31 2017, 12:36 PM · Typeahead, Projects, Maniphest, Feature Request
epriestley merged task T12486: Maniphest Search exclude-by-tag doesn't work consistently with subprojects into T12438: Project tokenizer functions like "any()" and "not()" do not include descendants.
Mar 31 2017, 12:36 PM · Search, Bug Report
shandor created T12486: Maniphest Search exclude-by-tag doesn't work consistently with subprojects.
Mar 31 2017, 10:19 AM · Search, Bug Report

Mar 30 2017

20after4 updated the task description for T12450: New Search Configuration Errata.
Mar 30 2017, 6:11 PM · Search
20after4 added a comment to T12450: New Search Configuration Errata.

So I ran into one problem when deploying the latest code to WMF production. We now throw a setup error if we have a cluster with no readable hosts. It actually makes sense to have a cluster that is write-only so that setup error is bogus.

Mar 30 2017, 6:10 PM · Search
20after4 added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Mar 30 2017, 6:09 PM · Search
20after4 added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Mar 30 2017, 6:09 PM · Search

Mar 28 2017

epriestley added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Mar 28 2017, 10:18 PM · Search
20after4 added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Mar 28 2017, 10:07 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Mar 28 2017, 8:59 PM · Search
epriestley added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Mar 28 2017, 8:54 PM · Search
epriestley added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Mar 28 2017, 7:58 PM · Search
epriestley added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Mar 28 2017, 7:55 PM · Search
epriestley added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Mar 28 2017, 7:51 PM · Search
epriestley added a comment to T12450: New Search Configuration Errata.

bin/search init warns me that the index is "incorrect". It might be more clear to distinguish between "missing" and "incorrect", since it's more comforting to users to see "everything is as we expect, doing normal first-time setup now" than "something is wrong, fixing it".

Mar 28 2017, 7:13 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Mar 28 2017, 11:30 AM · Search