Page MenuHomePhabricator
Feed Advanced Search

Sep 17 2015

jpb0104 added a comment to T9434: Conduit Error On audit.query - Attempting to access attached data on PhabricatorRepositoryCommit.

Querying by authorPHIDs works.

Sep 17 2015, 1:42 PM · Conduit
jpb0104 created T9434: Conduit Error On audit.query - Attempting to access attached data on PhabricatorRepositoryCommit.
Sep 17 2015, 1:40 PM · Conduit

Sep 16 2015

chad added projects to Q137: API repository.create Hosted: Diffusion, Conduit.
Sep 16 2015, 3:52 PM · Conduit, Diffusion

Sep 13 2015

• ivan-1986 closed Restricted Maniphest Task, a subtask of T9319: Accessing image file in Diffusion must not generate error (unhandled exception), as Spite.
Sep 13 2015, 10:00 AM · Phacility, Diffusion, Phacility Support

Sep 11 2015

Pawka closed T9395: harbormaster.sendmessage does not update build status for the same build target. as Wontfix.

Thanks for info!

Sep 11 2015, 1:44 PM · Harbormaster, Conduit
epriestley added a comment to T9395: harbormaster.sendmessage does not update build status for the same build target..

Broadly, this behavior is expected.

Sep 11 2015, 1:36 PM · Harbormaster, Conduit
Pawka added a comment to T9395: harbormaster.sendmessage does not update build status for the same build target..

Usually we are restarting builds on Jenkins if they failed due some environment issue. For example connection problems or git misconfiguration. If other words if build failed not because of code changes in diff, we restart build on Jenkins.

Sep 11 2015, 1:13 PM · Harbormaster, Conduit
epriestley added a comment to T9395: harbormaster.sendmessage does not update build status for the same build target..

Is Jenkins restarting the build automatically, or is a human going into Jenkins and clicking "restart"?

Sep 11 2015, 1:13 PM · Harbormaster, Conduit
cburroughs updated subscribers of T9395: harbormaster.sendmessage does not update build status for the same build target..
Sep 11 2015, 12:59 PM · Harbormaster, Conduit
Pawka added a project to T9395: harbormaster.sendmessage does not update build status for the same build target.: Harbormaster.
Sep 11 2015, 12:46 PM · Harbormaster, Conduit
Pawka created T9395: harbormaster.sendmessage does not update build status for the same build target..
Sep 11 2015, 12:46 PM · Harbormaster, Conduit

Sep 10 2015

angie moved T8835: Replacement for actAsUser in Conduit API from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 10 2015, 4:53 PM · Restricted Project, Conduit
angie moved T7304: Add CORS support to Conduit API from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 10 2015, 4:50 PM · Restricted Project, Conduit
epriestley closed T7304: Add CORS support to Conduit API as Wontfix.

I don't plan to pursue this. We'll offer JS access to the OAuth API instead (see T7303).

Sep 10 2015, 1:35 AM · Restricted Project, Conduit
epriestley closed T8835: Replacement for actAsUser in Conduit API as Wontfix.

See above.

Sep 10 2015, 12:44 AM · Restricted Project, Conduit

Sep 6 2015

joshuaspence triaged T9063: Conduit application search as Wishlist priority.
Sep 6 2015, 8:17 AM · Contributor Onboarding, Restricted Project, Conduit

Sep 3 2015

epriestley closed T9334: Improve documentation for differential.setdiffproperty as Wontfix.

It's very hard for us to prioritize work which doesn't actually solve real problems, or where we don't understand the greater need. This is why we ask users to describe problems and avoid hypotheticals in the guide describing how to file good feature requests.

Sep 3 2015, 4:51 PM · Conduit
sharwell added a comment to T9334: Improve documentation for differential.setdiffproperty.

What are you trying to accomplish?

Sep 3 2015, 4:40 PM · Conduit
epriestley added a comment to T9334: Improve documentation for differential.setdiffproperty.

What are you trying to accomplish?

Sep 3 2015, 3:44 PM · Conduit
sharwell created T9334: Improve documentation for differential.setdiffproperty.
Sep 3 2015, 3:24 PM · Conduit

Sep 2 2015

epriestley added a parent task for T9319: Accessing image file in Diffusion must not generate error (unhandled exception): T9303: Improve Phacility Onboarding/NUX.
Sep 2 2015, 2:31 PM · Phacility, Diffusion, Phacility Support
epriestley moved T9319: Accessing image file in Diffusion must not generate error (unhandled exception) from Backlog to Onboarding/NUX on the Phacility board.
Sep 2 2015, 2:31 PM · Phacility, Diffusion, Phacility Support
epriestley added a project to T9319: Accessing image file in Diffusion must not generate error (unhandled exception): Phacility.
Sep 2 2015, 2:30 PM · Phacility, Diffusion, Phacility Support
epriestley triaged T9319: Accessing image file in Diffusion must not generate error (unhandled exception) as Normal priority.
Sep 2 2015, 2:30 PM · Phacility, Diffusion, Phacility Support

Aug 31 2015

epriestley closed T9290: Cookie based API instead of OAuth as Wontfix.

I don't plan to pursue this. I consider it highly desirable that users must explicitly grant permission to OAuth clients.

Aug 31 2015, 10:43 AM · Conduit
joshuaspence added a project to T9290: Cookie based API instead of OAuth: Conduit.
Aug 31 2015, 8:58 AM · Conduit

Aug 30 2015

joshuaspence added a project to T8793: Allow local repository with conduit repository.create: Diffusion.
Aug 30 2015, 5:29 AM · Diffusion, Conduit

Aug 25 2015

joshuaspence added a project to T8956: Getting PHID data in one api call: Conduit.
Aug 25 2015, 9:48 PM · Conduit

Aug 23 2015

joshuaspence claimed T9063: Conduit application search.
Aug 23 2015, 12:02 PM · Contributor Onboarding, Restricted Project, Conduit
joshuaspence added projects to T9198: Get list of repos in diffusion over ssh: Conduit, Diffusion.
Aug 23 2015, 3:26 AM · Diffusion, Conduit

Aug 19 2015

epriestley added a comment to T8143: Allow creation of Conduit API Tokens for bots.

Use arc call-conduit, not arc install-certificate.

Aug 19 2015, 12:33 AM · Conduit
hofan41 added a comment to T8143: Allow creation of Conduit API Tokens for bots.
arc install-certificate --conduit-token api-XXXXXXXXX

Does not work. It still prompts for an API token instead of taking in the cli parameter.

Aug 19 2015, 12:27 AM · Conduit
epriestley closed T8143: Allow creation of Conduit API Tokens for bots as Resolved.

Use --conduit-token.

Aug 19 2015, 12:21 AM · Conduit
hofan41 reopened T8143: Allow creation of Conduit API Tokens for bots as "Open".

This is not resolved because the web interface to generate api tokens does not generate cli tokens that arc install-certificate asks for.

Aug 19 2015, 12:18 AM · Conduit

Aug 11 2015

epriestley added a comment to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.

I think T9132 is the most promising approach for reducing the complexity in exposing transaction writes in a general way.

Aug 11 2015, 1:32 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a subtask for T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: T9132: Build an ApplicationEditor abstraction.
Aug 11 2015, 1:32 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit

Aug 10 2015

epriestley updated subscribers of T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Aug 10 2015, 6:16 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit

Aug 8 2015

epriestley closed T8457: harbormaster.sendmessage return with invalid type is a bit too terse as Wontfix.

We currently allow any message, we just don't do anything with messages we don't understand. Possibly this should be made more strict, but I imagine accepting any message and possibly letting extensions handle them in the future. We might not be able to figure out if anything will accept a message or not when we receive it.

Aug 8 2015, 7:11 PM · Conduit, Harbormaster

Aug 4 2015

joshuaspence added a comment to T9063: Conduit application search.

Screenshot_2015-08-05-06-32-24.png (1×1 px, 229 KB)

Aug 4 2015, 8:33 PM · Contributor Onboarding, Restricted Project, Conduit
chad added a comment to T9063: Conduit application search.

I'm not sure where you want this typeahead?

Aug 4 2015, 2:14 PM · Contributor Onboarding, Restricted Project, Conduit
joshuaspence created T9063: Conduit application search.
Aug 4 2015, 9:17 AM · Contributor Onboarding, Restricted Project, Conduit

Jul 27 2015

ox created T8975: Reference variable for the current user on Conduit Method Call page.
Jul 27 2015, 9:47 PM · Conduit

Jul 25 2015

chad updated subscribers of T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Jul 25 2015, 2:23 AM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit

Jul 22 2015

epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Okay, can you file a separate issue for that and I'll try to reproduce it? That's bad and not the expected queue behavior.

Jul 22 2015, 2:13 PM · Restricted Project, Auth, Conduit
hach-que added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Generally we find that the commit / message parser tasks tend to get done first, and take up taskmasters that could be processing Harbormaster builds. This delays builds because we have less taskmasters available.

Jul 22 2015, 1:40 PM · Restricted Project, Auth, Conduit
epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

commits without UTF8 data in them effectively block the queue.

Jul 22 2015, 1:36 PM · Restricted Project, Auth, Conduit
hach-que added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

@epriestley Is there an ETA on this? It's been 7 days since I cleared out failing Git parser tasks and there's another 20 I need to clear out now. This issue has a significant impact on our background processing because commits without UTF8 data in them effectively block the queue.

Jul 22 2015, 5:42 AM · Restricted Project, Auth, Conduit

Jul 16 2015

epriestley merged T8857: Make Git commit / message parsers eventually fail or de-prioritize on failure into T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Jul 16 2015, 7:42 PM · Restricted Project, Auth, Conduit

Jul 14 2015

epriestley added a comment to T8835: Replacement for actAsUser in Conduit API.

We don't plan to restore actAsUser in any form to the upstream, since it violates policies and can not be made safe (in the sense of not-policy-violating).

Jul 14 2015, 2:20 PM · Restricted Project, Conduit
eadler moved T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges from Backlog to Important on the FreeBSD board.
Jul 14 2015, 4:38 AM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
eadler added a project to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: FreeBSD.
Jul 14 2015, 4:38 AM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
chad updated subscribers of T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Jul 14 2015, 4:06 AM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
chad merged task T8825: Enhance Conduit API for managing projects into T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Jul 14 2015, 4:06 AM · Conduit

Jul 13 2015

jhurwitz updated subscribers of T8835: Replacement for actAsUser in Conduit API.
Jul 13 2015, 9:41 PM · Restricted Project, Conduit
jhurwitz created T8835: Replacement for actAsUser in Conduit API.
Jul 13 2015, 9:40 PM · Restricted Project, Conduit

Jul 11 2015

ximion created T8825: Enhance Conduit API for managing projects.
Jul 11 2015, 12:21 AM · Conduit

Jul 9 2015

tao_qiping closed T8722: Custom field with users goes wrong when create task via maniphest.createtask API as Resolved.

Thanks chad. It is not require you to support our code, but confirming if there is any bug in API, or how to use API.

Jul 9 2015, 6:00 AM · Conduit
chad added a comment to T8722: Custom field with users goes wrong when create task via maniphest.createtask API .

pasted_file (474×906 px, 55 KB)

Jul 9 2015, 2:35 AM · Conduit
chad added a comment to T8722: Custom field with users goes wrong when create task via maniphest.createtask API .

This generally falls outside what we provide free support for:
https://secure.phabricator.com/book/phabcontrib/article/bug_reports/#supported-issues

Jul 9 2015, 2:33 AM · Conduit
tao_qiping added a comment to T8722: Custom field with users goes wrong when create task via maniphest.createtask API .

any findings? it blocks us for a internal tool.

Jul 9 2015, 2:02 AM · Conduit

Jul 8 2015

epriestley added a revision to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: Restricted Differential Revision.
Jul 8 2015, 1:41 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley updated subscribers of T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Jul 8 2015, 1:40 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley merged task T8793: Allow local repository with conduit repository.create into T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Jul 8 2015, 1:40 PM · Diffusion, Conduit
azerttyu added a revision to T8793: Allow local repository with conduit repository.create: Restricted Differential Revision.
Jul 8 2015, 12:57 PM · Diffusion, Conduit
azerttyu created T8793: Allow local repository with conduit repository.create.
Jul 8 2015, 11:51 AM · Diffusion, Conduit

Jul 7 2015

epriestley added a comment to T7903: Conduit differential.query search by branches is broken.

No. If there was, it would be posted here.

Jul 7 2015, 12:41 PM · Restricted Project, Differential, Conduit
d.ananyev added a comment to T7903: Conduit differential.query search by branches is broken.

Are there any news about this issue?

Jul 7 2015, 12:40 PM · Restricted Project, Differential, Conduit

Jul 6 2015

eadler moved T4184: API does not contain user.create from Backlog to Important on the FreeBSD board.
Jul 6 2015, 1:59 AM · Restricted Project, FreeBSD, Conduit, Auth
eadler added a comment to T4184: API does not contain user.create.

FreeBSD has very strong interest in this sort of API call. It would permit us to integrate better with certain systems that are not part of phabricator. It also makes writing a migration script entirely against conduit feasable.

Jul 6 2015, 1:59 AM · Restricted Project, FreeBSD, Conduit, Auth
eadler added a project to T4184: API does not contain user.create: FreeBSD.
Jul 6 2015, 1:58 AM · Restricted Project, FreeBSD, Conduit, Auth

Jul 4 2015

chad updated subscribers of T8722: Custom field with users goes wrong when create task via maniphest.createtask API .
Jul 4 2015, 3:41 PM · Conduit
chad removed 1 mock(s) for T8722: Custom field with users goes wrong when create task via maniphest.createtask API : M1435: Brokens?.
Jul 4 2015, 3:41 PM · Conduit
• frankth added 1 mock(s) for T8722: Custom field with users goes wrong when create task via maniphest.createtask API : M1435: Brokens?.
Jul 4 2015, 1:43 PM · Conduit
• frankth added a comment to T8722: Custom field with users goes wrong when create task via maniphest.createtask API .

good !

Jul 4 2015, 1:42 PM · Conduit

Jul 3 2015

tao_qiping added a comment to T8722: Custom field with users goes wrong when create task via maniphest.createtask API .

but when I passed a string, error again. and actually when I create task in page, we can select multiple users.

Jul 3 2015, 6:35 AM · Conduit
chad added a comment to T8722: Custom field with users goes wrong when create task via maniphest.createtask API .

The error message says it expects a string and you are passing an array.

Jul 3 2015, 6:13 AM · Conduit
tao_qiping added a comment to T8722: Custom field with users goes wrong when create task via maniphest.createtask API .

anyone looking at this?
I attached log file.

Jul 3 2015, 5:52 AM · Conduit
chad changed the visibility for T2968: In conduit, make auto resolve task via review land look the same as manual resolve.
Jul 3 2015, 4:56 AM · Restricted Project, Conduit
chad changed the visibility for T550: Build an SSH conduit client.
Jul 3 2015, 4:56 AM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit

Jul 2 2015

tao_qiping added a comment to T8722: Custom field with users goes wrong when create task via maniphest.createtask API .

Is there a stack trace for that error in your error log (often /var/log/apache2/error.log or similar)?

That's not an error I recognize.

Jul 2 2015, 1:27 AM · Conduit
tao_qiping updated the task description for T8722: Custom field with users goes wrong when create task via maniphest.createtask API .
Jul 2 2015, 1:26 AM · Conduit

Jun 30 2015

chad shifted T8722: Custom field with users goes wrong when create task via maniphest.createtask API from the S3 Hyperspace space to the S1 Core space.
Jun 30 2015, 1:31 PM · Conduit
epriestley added a comment to T8722: Custom field with users goes wrong when create task via maniphest.createtask API .

Is there a stack trace for that error in your error log (often /var/log/apache2/error.log or similar)?

Jun 30 2015, 12:12 PM · Conduit
tao_qiping created T8722: Custom field with users goes wrong when create task via maniphest.createtask API .
Jun 30 2015, 7:03 AM · Conduit

Jun 26 2015

epriestley updated subscribers of T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Jun 26 2015, 3:45 AM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit

Jun 25 2015

epriestley updated subscribers of T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Jun 25 2015, 11:34 AM · Restricted Project, Auth, Conduit
epriestley merged task T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE into T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Jun 25 2015, 11:34 AM · Diffusion, Conduit
hach-que renamed T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE from Empty response from Conduit when diffusion.rawdiffquery is called to Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE.
Jun 25 2015, 4:57 AM · Diffusion, Conduit
hach-que added a comment to T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE.
php -r '$content = file_get_contents("/tmp/diff"); $content = iconv("UTF-8", "UTF-8//IGNORE", $content); echo $content;'  | python -c 'import json,sys; print json.dumps(sys.stdin.read())'
Jun 25 2015, 4:55 AM · Diffusion, Conduit
hach-que added a comment to T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE.

Yeah, the diff contains invalid UTF8:

Jun 25 2015, 4:52 AM · Diffusion, Conduit
hach-que added a comment to T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE.

Well, I think we're in a bad position, because this code:

Jun 25 2015, 4:49 AM · Diffusion, Conduit
hach-que added a comment to T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE.

to line 27 of AphrontJSONResponse (right after it constructs the JSON), shows:

Jun 25 2015, 4:46 AM · Diffusion, Conduit
hach-que added a comment to T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE.

to line 147 of PhabricatorConduitAPIController shows that the diff content does pass through this line at least once.

Jun 25 2015, 4:43 AM · Diffusion, Conduit
hach-que added a comment to T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE.

Adding file_put_contents('/tmp/diff3', $result); on line 92 of PhabricatorConduitAPIController.php shows that the result is still correctly stored at this point.

Jun 25 2015, 4:39 AM · Diffusion, Conduit
hach-que added a comment to T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE.

at line 136 of DiffusionQueryConduitAPIMethod on the storage tier results in the file having the diff content, so the issue must be further on than this.

Jun 25 2015, 4:33 AM · Diffusion, Conduit
hach-que added a comment to T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE.

When I change line 119 of DiffusionQueryConduitAPIMethod.php to:

Jun 25 2015, 4:25 AM · Diffusion, Conduit
hach-que added a comment to T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE.

I'm like 95% sure this has something to do with the content of the actual diff returned, like UTF-8 encoding or something like that...

Jun 25 2015, 4:18 AM · Diffusion, Conduit
hach-que added a comment to T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE.

Something is totally whack with the cluster configuration in the latest HEAD. For some reason, the storage tier is now constructing a Conduit client to code.pageuppeople.com, even though it should just run the command locally. Even worse, the $is_cluster_request variable is set to true, yet it still constructs a new Conduit client.

Jun 25 2015, 4:16 AM · Diffusion, Conduit
hach-que added a comment to T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE.

For some reason, the storage tier is attempting to forward the request on to another machine inside the cluster (presumably itself?) and is then recursing. This makes no sense given that the code in src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php at line 123 is designed to prevent recursion.

Jun 25 2015, 4:08 AM · Diffusion, Conduit
hach-que added a comment to T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE.

I ran the query directly against the Conduit API on the storage machine, from my local machine, and it returns an empty response (so it's got nothing to do with the requesting machine):

Jun 25 2015, 3:51 AM · Diffusion, Conduit