Page MenuHomePhabricator
Feed Advanced Search

Apr 12 2015

joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 9:34 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 9:23 PM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Restricted Differential Revision.
Apr 12 2015, 9:20 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 9:19 PM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Restricted Differential Revision.
Apr 12 2015, 9:07 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 9:06 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 9:03 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 9:02 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 1:08 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 1:05 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 1:04 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 1:03 PM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Restricted Differential Revision.
Apr 12 2015, 12:59 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 12:56 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 12:53 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 12:09 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 12:08 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 12:06 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 12:01 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 12:00 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 11:59 AM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 11:49 AM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Restricted Differential Revision.
Apr 12 2015, 11:35 AM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Restricted Differential Revision.
Apr 12 2015, 11:24 AM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 10:21 AM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Restricted Differential Revision.
Apr 12 2015, 10:05 AM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 8:52 AM · Lint

Apr 9 2015

cburroughs added a comment to T7780: Add linter for Foodcritic.

It's included in the 'chef development kit' now so almost everyone using chef has it. So at least as popular as the puppet linter ;-)

Apr 9 2015, 8:13 PM · Restricted Project, Lint
avivey added a comment to T7780: Add linter for Foodcritic.

The wait list for merging in any lint change is very long right now (Some stuff has been waiting for months).

Apr 9 2015, 7:54 PM · Restricted Project, Lint

Apr 8 2015

joshuaspence added a revision to T7409: Implement PHPCS lints: Restricted Differential Revision.
Apr 8 2015, 1:57 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 8 2015, 1:56 PM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Restricted Differential Revision.
Apr 8 2015, 1:42 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 8 2015, 1:41 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 8 2015, 1:28 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 8 2015, 1:24 PM · Lint
michaeloa created T7780: Add linter for Foodcritic.
Apr 8 2015, 9:26 AM · Restricted Project, Lint

Apr 6 2015

joshuaspence closed T7464: jshint.jshintignore not working as Resolved by committing Restricted Diffusion Commit.
Apr 6 2015, 9:26 PM · Lint
joshuaspence added a revision to T7464: jshint.jshintignore not working: Restricted Differential Revision.
Apr 6 2015, 12:36 PM · Lint

Mar 27 2015

epriestley updated subscribers of T7674: Remove support for arc commit hooks.
Mar 27 2015, 12:34 PM · Lint, Arcanist
epriestley added a subtask for T7674: Remove support for arc commit hooks: T5064: Make `arc land` run unit tests and lint.
Mar 27 2015, 12:33 PM · Lint, Arcanist
epriestley created T7674: Remove support for arc commit hooks.
Mar 27 2015, 12:32 PM · Lint, Arcanist

Mar 23 2015

joshuaspence added a revision to T7409: Implement PHPCS lints: Restricted Differential Revision.
Mar 23 2015, 8:23 PM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Restricted Differential Revision.
Mar 23 2015, 1:13 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Mar 23 2015, 12:55 PM · Lint

Mar 20 2015

sectioneight added a revision to T6867: Add linter and unit test engine for Go(lang): Restricted Differential Revision.
Mar 20 2015, 10:28 PM · Lint

Mar 16 2015

igorgatis added a comment to T7091: Grep Linter.

ArcanistMergeConflictLinter does 99% of the job and it is language agnostic. GrepLinter sounds like a very handy tool, IMO.

Mar 16 2015, 12:12 PM · Lint, Arcanist

Mar 12 2015

staticshock added a project to T7527: `arc lint` doesn't show lint warnings in powershell, cmd.exe, and git bash: Windows.
Mar 12 2015, 6:41 PM · Windows, Lint
staticshock renamed T7527: `arc lint` doesn't show lint warnings in powershell, cmd.exe, and git bash from `arc lint` doesn't show lint warnings in powershell / cmd.exe to `arc lint` doesn't show lint warnings in powershell, cmd.exe, and git bash.
Mar 12 2015, 4:29 PM · Windows, Lint

Mar 11 2015

staticshock updated the task description for T7527: `arc lint` doesn't show lint warnings in powershell, cmd.exe, and git bash.
Mar 11 2015, 2:48 PM · Windows, Lint
staticshock added a revision to T7527: `arc lint` doesn't show lint warnings in powershell, cmd.exe, and git bash: Restricted Differential Revision.
Mar 11 2015, 2:46 PM · Windows, Lint
staticshock created T7527: `arc lint` doesn't show lint warnings in powershell, cmd.exe, and git bash.
Mar 11 2015, 2:45 PM · Windows, Lint

Mar 8 2015

joshuaspence claimed T7464: jshint.jshintignore not working.
Mar 8 2015, 1:15 AM · Lint
joshuaspence edited projects for T7464: jshint.jshintignore not working, added: Lint; removed Arcanist.
Mar 8 2015, 1:15 AM · Lint

Mar 5 2015

epriestley added a comment to T7462: Undeclared variable lint doesn't work at top-level scope.

In the general case, there are approximately one hundred trillion PHP files out there which do this:

Mar 5 2015, 1:09 PM · Lint
joshuaspence created T7462: Undeclared variable lint doesn't work at top-level scope.
Mar 5 2015, 5:51 AM · Lint

Mar 3 2015

epriestley added a comment to T7412: Allow a project to have multiple `arclint` files.

I merged T7037 and T6908 here because they both deal (approximately) with templating .arclint files, and we're definitely not doing the magic approaches in T6908 where some linters get to ignore global excludes.

Mar 3 2015, 11:35 AM · Lint
epriestley merged task T6908: Run chmod linter on global excludes into T7412: Allow a project to have multiple `arclint` files.
Mar 3 2015, 11:30 AM · Lint
epriestley updated subscribers of T7412: Allow a project to have multiple `arclint` files.
Mar 3 2015, 11:30 AM · Lint
epriestley merged task T7037: Allow `.arclint` files to be templated into T7412: Allow a project to have multiple `arclint` files.
Mar 3 2015, 11:30 AM · Lint

Mar 1 2015

joshuaspence renamed T7416: Write a linter rule to determine appropriate constant definitions from Write a linter rule to de to Write a linter rule to determine appropriate constant definitions.
Mar 1 2015, 9:52 PM · Lint
joshuaspence triaged T7409: Implement PHPCS lints as Wishlist priority.
Mar 1 2015, 9:15 PM · Lint
joshuaspence triaged T7417: Write a linter rule for method modifier ordering as Wishlist priority.
Mar 1 2015, 9:13 PM · Lint
joshuaspence created T7417: Write a linter rule for method modifier ordering.
Mar 1 2015, 9:12 PM · Lint
joshuaspence claimed T7409: Implement PHPCS lints.
Mar 1 2015, 9:09 PM · Lint
joshuaspence created T7416: Write a linter rule to determine appropriate constant definitions.
Mar 1 2015, 9:08 PM · Lint
joshuaspence created T7415: Write a linter rule to detect when a class name is used instead of self.
Mar 1 2015, 9:07 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Mar 1 2015, 9:05 PM · Lint
joshuaspence updated the task description for T7412: Allow a project to have multiple `arclint` files.
Mar 1 2015, 8:53 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Mar 1 2015, 8:45 PM · Lint
joshuaspence added a comment to T7412: Allow a project to have multiple `arclint` files.

Let me update the description on this ticket to provide more context, I filed it real quick so that I wouldn't forget about it.

Mar 1 2015, 8:23 PM · Lint
joshuaspence added a comment to T7412: Allow a project to have multiple `arclint` files.

I also think it would probably be reasonable to do this:

  • If a configuration file like .arclint is not executable, read the file content to load configuration.
  • If a configuration file like .arclint is executable, execute it. Read stdout to load configuration.
Mar 1 2015, 8:22 PM · Lint
avivey added a comment to T7412: Allow a project to have multiple `arclint` files.

.arclint is very powerful already, with include-exclude regexps; What's the use-case for having several?

Mar 1 2015, 8:11 PM · Lint
epriestley added a comment to T7412: Allow a project to have multiple `arclint` files.

I also think it would probably be reasonable to do this:

Mar 1 2015, 3:18 PM · Lint
epriestley added a comment to T7412: Allow a project to have multiple `arclint` files.

I generally don't think we should support this, and installs which have complex .arclint requirements should instead write a script which builds .arclint for them. If you want 5 files with a bunch of variables in them: write bin/rebuild-lint.py or whatever, have it merge the files and do variable replacement, and dump it to .arclint. This script is probably 10 lines long and can do exactly what your environment requires.

Mar 1 2015, 3:16 PM · Lint
joshuaspence created T7412: Allow a project to have multiple `arclint` files.
Mar 1 2015, 12:35 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Mar 1 2015, 12:33 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Mar 1 2015, 4:02 AM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Mar 1 2015, 4:01 AM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Mar 1 2015, 3:53 AM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Mar 1 2015, 3:40 AM · Lint
joshuaspence created T7409: Implement PHPCS lints.
Mar 1 2015, 3:36 AM · Lint

Feb 28 2015

joshuaspence claimed T7215: ArcanistXMLLinterTestCase test failure.
Feb 28 2015, 12:13 PM · Lint

Feb 18 2015

michel-slm added a revision to T7293: Add support for ansible-lint: Restricted Differential Revision.
Feb 18 2015, 5:41 AM · Arcanist, Lint
michel-slm added a comment to T7293: Add support for ansible-lint.

Patch is currently here - we needed this in production so we wrote it and then looked at the contribution guide later.

Feb 18 2015, 4:21 AM · Arcanist, Lint

Feb 17 2015

michel-slm added a project to T7293: Add support for ansible-lint: Arcanist.
Feb 17 2015, 11:41 AM · Arcanist, Lint
michel-slm created T7293: Add support for ansible-lint.
Feb 17 2015, 11:40 AM · Arcanist, Lint

Feb 11 2015

joshuaspence triaged T7045: Allow linters to be skipped as Normal priority.
Feb 11 2015, 8:55 PM · Differential, Lint
joshuaspence claimed T7045: Allow linters to be skipped.
Feb 11 2015, 8:53 PM · Differential, Lint

Feb 10 2015

joshuaspence added a revision to T7046: Add a linter rule for detecting missing variables for `pht`: Restricted Differential Revision.
Feb 10 2015, 8:18 AM · Lint
joshuaspence closed T7046: Add a linter rule for detecting missing variables for `pht` as Resolved by committing Restricted Diffusion Commit.
Feb 10 2015, 7:45 AM · Lint

Feb 9 2015

staticshock added a comment to T7214: ArcanistPyLintLinterTestCase test failure.

See T5222 for a related pylint discussion

Feb 9 2015, 5:40 PM · Lint

Feb 8 2015

avivey added a comment to T7214: ArcanistPyLintLinterTestCase test failure.

... or kicked out in favor of flake8, which is modernized, and runs all(?) other python linters available.

Feb 8 2015, 9:33 PM · Lint
chad edited projects for T7215: ArcanistXMLLinterTestCase test failure, added: Lint; removed Arcanist.
Feb 8 2015, 9:22 PM · Lint
chad edited projects for T7214: ArcanistPyLintLinterTestCase test failure, added: Lint; removed Arcanist.
Feb 8 2015, 9:22 PM · Lint
joshuaspence added a comment to T7170: Support beta versions of PHP Code Sniffer.

OK, so I have a couple of thoughts:

Feb 8 2015, 8:53 PM · Lint
beber added a comment to T7170: Support beta versions of PHP Code Sniffer.

Does the ArcanistPhpcsLinterTestCase::testLinter test execute successfully?

Feb 8 2015, 8:45 PM · Lint
joshuaspence added a comment to T7170: Support beta versions of PHP Code Sniffer.

Does the ArcanistPhpcsLinterTestCase::testLinter test execute successfully?

Feb 8 2015, 8:41 PM · Lint
chad updated the task description for T7170: Support beta versions of PHP Code Sniffer.
Feb 8 2015, 8:40 PM · Lint
beber updated the task description for T7170: Support beta versions of PHP Code Sniffer.
Feb 8 2015, 8:37 PM · Lint
beber updated the task description for T7170: Support beta versions of PHP Code Sniffer.
Feb 8 2015, 8:36 PM · Lint