Page MenuHomePhabricator
Create Task
Maniphest T7214

ArcanistPyLintLinterTestCase test failure
Open, Needs TriagePublic
Actions

Description

Using arcanist on git commit 59640f7eae3f7c0a352c18e784fb55acb7967991, the following error can be seen:

$  bin/arc unit --everything --no-coverage
   FAIL  ArcanistPyLintLinterTestCase::testLinter
In 'pylint.lint-test', expected lint to raise warning on line 1 at char 0, but no warning was raised. Actually raised:
  disabled at line 1, char 0: W0611 PyLint W0611
  disabled at line 1, char 0: C0111 PyLint C0111
  disabled at line 1, char 0: W0611 PyLint W0611
  disabled at line 3, char 0: E0602 PyLint E0602

pylint config have been made that way:

  • $ bin/arc set-config --local lint.pylint.codes.advice '^(C|R).*'
  • $ bin/arc set-config --local lint.pylint.codes.error '^(E|F).*'
  • $ bin/arc set-config --local lint.pylint.codes.warning '^W.*'

Would not it be nice to provide a default pylint config ?

Related Objects

Event Timeline

beber created this task.Feb 8 2015, 8:38 PM
beber raised the priority of this task from to Needs Triage.
beber updated the task description. (Show Details)
beber added a project: Arcanist.
beber added a subscriber: beber.
joshuaspence added a subscriber: joshuaspence.Feb 8 2015, 8:58 PM

ArcanistPylintLinter is fairly odd and needs to be modernized to support the .arclint format, I believe.

chad edited projects, added Lint; removed Arcanist.Feb 8 2015, 9:22 PM
avivey added a subscriber: avivey.Feb 8 2015, 9:33 PM

... or kicked out in favor of flake8, which is modernized, and runs all(?) other python linters available.

staticshock added a subscriber: staticshock.Feb 9 2015, 5:40 PM

See T5222 for a related pylint discussion

Phabricator · Built by Phacility