Page MenuHomePhabricator
Feed Advanced Search

Nov 8 2014

qgil created T6502: Policy to define who can move cards in a workboard.
Nov 8 2014, 3:13 PM · Projects, Wikimedia, Policy, Workboards
btrahan added a revision to T6496: Phriction should check for edit permissions on x/y/ before letting you create x/y/z/: Restricted Differential Revision.
Nov 8 2014, 6:47 AM · Policy, Phriction
btrahan closed T6497: PhrictionDocumentQuery still has a project-respecting hunk of code as Resolved.

Closed by commit rPb655699a6cfb.

Nov 8 2014, 6:34 AM · Policy, Phriction
epriestley added a comment to T6495: Phriction document titles are visible even if you can't see the document.

To see x/y/z/ you have to be able to see x/ and x/y/, so it should be moot I think.

Nov 8 2014, 3:03 AM · Policy, Phriction
btrahan added a comment to T6495: Phriction document titles are visible even if you can't see the document.

Implementation wise, I think the handle fix is the way to go, mainly because....

Nov 8 2014, 2:20 AM · Policy, Phriction
btrahan claimed T6496: Phriction should check for edit permissions on x/y/ before letting you create x/y/z/.
Nov 8 2014, 2:13 AM · Policy, Phriction
btrahan added a revision to T6497: PhrictionDocumentQuery still has a project-respecting hunk of code : Restricted Differential Revision.
Nov 8 2014, 2:11 AM · Policy, Phriction
btrahan claimed T6497: PhrictionDocumentQuery still has a project-respecting hunk of code .

word

Nov 8 2014, 12:45 AM · Policy, Phriction
epriestley created T6497: PhrictionDocumentQuery still has a project-respecting hunk of code .
Nov 8 2014, 12:44 AM · Policy, Phriction
epriestley updated subscribers of T6496: Phriction should check for edit permissions on x/y/ before letting you create x/y/z/.

This is mostly a product question so maybe @chad has some input on expectations / reasonableness.

Nov 8 2014, 12:39 AM · Policy, Phriction
epriestley created T6496: Phriction should check for edit permissions on x/y/ before letting you create x/y/z/.
Nov 8 2014, 12:38 AM · Policy, Phriction
btrahan claimed T6495: Phriction document titles are visible even if you can't see the document.

I'm done-ish for today but I figure I should slap this on the ole queue.

Nov 8 2014, 12:35 AM · Policy, Phriction
epriestley created T6495: Phriction document titles are visible even if you can't see the document.
Nov 8 2014, 12:32 AM · Policy, Phriction

Nov 4 2014

chad updated subscribers of T4411: Adding a CC to a Maniphest Task should give View rights for that user.
Nov 4 2014, 3:07 AM · Wikimedia, Policy

Oct 30 2014

chad closed T6427: "Show Details" link in Maniphest requires anonymous users to login, a subtask of T4830: Applications with Public permissions requiring users to login, as Resolved.
Oct 30 2014, 3:36 PM · Facts, Policy, People

Oct 22 2014

• philippe.jadin added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

Might be interesting to extend the Herald module ala Drupal rules (https://www.drupal.org/project/rules) so it can react to more events with more actions. Uber powerful stuff.

Oct 22 2014, 2:39 PM · Spaces, Wikimedia, Policy
chad added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

@michaeloa our current expectation for that is for you to write an registration event listener, which gives you unlimited possibilities.

Oct 22 2014, 2:33 PM · Spaces, Wikimedia, Policy
michaeloa added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

Apologies if this has already been discussed, but a search didn't turn up anything. Putting this here, rather than starting a different task, as I guess the answer to the question will probably depend on how this task is solved.

Oct 22 2014, 1:44 PM · Spaces, Wikimedia, Policy

Oct 17 2014

chad added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

T4778 is how we prioritize, this task specifically is on our roadmap.

Oct 17 2014, 2:36 PM · Spaces, Wikimedia, Policy
anagromataf added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

I wonder what the state of this feature is. I really love to see this, because it's the only missing part stopping me to use phabricator to work together with clients.

Oct 17 2014, 10:23 AM · Spaces, Wikimedia, Policy

Oct 16 2014

epriestley closed T6332: Set visible/editable fields to first project policy by default when creating new tasks as Wontfix.

Yeah, we don't want this in the upstream. You can add your patch to the wiki page @chad linked, though.

Oct 16 2014, 2:40 PM · Maniphest, Policy
dmorissette added a comment to T6332: Set visible/editable fields to first project policy by default when creating new tasks.

Sure. But since that will likely be a simple patch and not an extension then we could simply add a ref to this ticket in the community_resources wiki page when the patch is ready. Unless its possible to implement a phabricator extension for UI JavaScript code but I dunno since we haven't looked into this yet.

Oct 16 2014, 2:39 PM · Maniphest, Policy
chad added a comment to T6332: Set visible/editable fields to first project policy by default when creating new tasks.

Maybe this could go here? https://secure.phabricator.com/w/community_resources/

Oct 16 2014, 2:20 PM · Maniphest, Policy
dmorissette added a project to T6332: Set visible/editable fields to first project policy by default when creating new tasks: Maniphest.
Oct 16 2014, 1:41 PM · Maniphest, Policy
dmorissette added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

@philippe.jadin: it's funny you suggest that as we had a very similar idea as you yesterday. We are are in the process of moving from Trac to Phabricator and have that same need for client-restricted projects. As an interim solution until namespaces or something similar is in place, we are planning to implement a small JavaScript patch in our local phabricator to do something similar to what you suggest here.

Oct 16 2014, 1:33 PM · Spaces, Wikimedia, Policy
dmorissette created T6332: Set visible/editable fields to first project policy by default when creating new tasks.
Oct 16 2014, 1:29 PM · Maniphest, Policy
• philippe.jadin added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

My 2 cents on this :

Oct 16 2014, 12:59 PM · Spaces, Wikimedia, Policy

Oct 9 2014

btrahan closed T6104: "Task Restricted Task" as Resolved.

Closed by commit rP45bb77531c79.

Oct 9 2014, 2:41 AM · Support Impact, Policy
btrahan added a revision to T6104: "Task Restricted Task": Restricted Differential Revision.
Oct 9 2014, 2:37 AM · Support Impact, Policy
btrahan claimed T6104: "Task Restricted Task".
Oct 9 2014, 2:36 AM · Support Impact, Policy

Oct 3 2014

epriestley added a comment to T4411: Adding a CC to a Maniphest Task should give View rights for that user.

In general, a user who can view a task can already take a screenshot of it and share it with whoever they want. I think of this as very similar to that, except that there's an audit log and the grant is revocable.

Oct 3 2014, 2:14 PM · Wikimedia, Policy
• chasemp added a comment to T4411: Adding a CC to a Maniphest Task should give View rights for that user.

I'm going to disagree here with the utmost respect.

Oct 3 2014, 2:04 PM · Wikimedia, Policy
epriestley added a project to T4411: Adding a CC to a Maniphest Task should give View rights for that user: Support Impact.

Support Impact The current behavior is unexpected and confusing.

Oct 3 2014, 4:21 AM · Wikimedia, Policy
epriestley added a project to T6104: "Task Restricted Task": Support Impact.

Support Impact This is confusing and trivial.

Oct 3 2014, 3:40 AM · Support Impact, Policy

Oct 1 2014

epriestley renamed T6207: Add a "Can Use Herald Rules" application permission from Admins should be able to disable/delete personal Herald rules to Add a "Can Use Herald Rules" application permission.
Oct 1 2014, 6:16 PM · Restricted Project, Policy, Herald
epriestley added a comment to T6207: Add a "Can Use Herald Rules" application permission.

(There's some fuzziness with the ruleset right now; I believe you can see the effects of their rules in transcripts, for example. Herald predates policies and is generally awkward to balance cleanly against them. There are things we could do better, but I think the major interactions are working correctly today.)

Oct 1 2014, 6:16 PM · Restricted Project, Policy, Herald
epriestley added a comment to T6207: Add a "Can Use Herald Rules" application permission.

It's expected that you can't see other users' personal rules. Administrators can't violate policies, and users' personal rules are private.

Oct 1 2014, 6:15 PM · Restricted Project, Policy, Herald

Sep 30 2014

• chasemp added a comment to T6207: Add a "Can Use Herald Rules" application permission.

One thing I do think could help, and maybe I'm just being an idiot. If I create a global rule as an admin, and then a non-admin user creates a personal rule. On my test installs I see both rules as the non-admin if I go to http://fabapi.wmflabs.org/herald/query/all/ but only the global rule as the admin. That seems weird? I would expect to see the same rules in both cases.

Sep 30 2014, 3:25 PM · Restricted Project, Policy, Herald
epriestley added a comment to T6207: Add a "Can Use Herald Rules" application permission.

I think separating this policy out is also probably worth doing eventually, but it looks like it doesn't solve any immediate problems.

Sep 30 2014, 2:40 PM · Restricted Project, Policy, Herald
epriestley triaged T6207: Add a "Can Use Herald Rules" application permission as Wishlist priority.
Sep 30 2014, 2:39 PM · Restricted Project, Policy, Herald
epriestley updated subscribers of T6207: Add a "Can Use Herald Rules" application permission.

I discussed the WMF situation in particular in more detail with @rush898 on IRC, and it looks like T6211 is a good path forward for the "security" case.

Sep 30 2014, 2:39 PM · Restricted Project, Policy, Herald

Sep 29 2014

qgil added a comment to T6207: Add a "Can Use Herald Rules" application permission.

Today:

  • Users with access to the Phabricator host can destroy the rule with bin/remove destroy Hxxx.
  • You can deactivate the rule by disabling the user's account.
Sep 29 2014, 7:42 PM · Restricted Project, Policy, Herald
epriestley added a comment to T6207: Add a "Can Use Herald Rules" application permission.

How about this:

Sep 29 2014, 7:35 PM · Restricted Project, Policy, Herald
epriestley added a comment to T6207: Add a "Can Use Herald Rules" application permission.

We're unlikely to expand the role of administrative power here, administrators intentionally have very little power. See:

Sep 29 2014, 7:30 PM · Restricted Project, Policy, Herald
qgil created T6207: Add a "Can Use Herald Rules" application permission.
Sep 29 2014, 6:47 PM · Restricted Project, Policy, Herald

Sep 25 2014

epriestley merged task T6192: Phriction drag and drop files permissions are too restrictive into T6034: Files not attaching correctly to Phriction pages.
Sep 25 2014, 10:30 PM · Phriction, Policy
bluehawk created T6192: Phriction drag and drop files permissions are too restrictive.
Sep 25 2014, 10:28 PM · Phriction, Policy
epriestley added a comment to T6189: Ponder file upload permissions are too restrictive.

Note that the fix won't apply retroactively, but if you edit existing questions (e.g., add a space or a period or something) that'll fix the files.

Sep 25 2014, 8:43 PM · Policy, Ponder
epriestley closed T6189: Ponder file upload permissions are too restrictive as Resolved.

Closed by commit rPf605780893b3.

Sep 25 2014, 8:42 PM · Policy, Ponder
epriestley claimed T6189: Ponder file upload permissions are too restrictive.
Sep 25 2014, 7:03 PM · Policy, Ponder
epriestley added a revision to T6189: Ponder file upload permissions are too restrictive: Restricted Differential Revision.
Sep 25 2014, 7:03 PM · Policy, Ponder
chad renamed T6189: Ponder file upload permissions are too restrictive from Ponder file upload permissions are too restrictive. to Ponder file upload permissions are too restrictive.
Sep 25 2014, 6:43 PM · Policy, Ponder
chad added a comment to T6189: Ponder file upload permissions are too restrictive.

I'm 67% certain you made that number up.

Sep 25 2014, 5:47 PM · Policy, Ponder
bluehawk added a comment to T6189: Ponder file upload permissions are too restrictive.

I think you mean un-Prototype :P

Sep 25 2014, 5:46 PM · Policy, Ponder
epriestley added a comment to T6189: Ponder file upload permissions are too restrictive.

I think there are still like 30 huge problems with it

Sep 25 2014, 5:46 PM · Policy, Ponder
chad added a comment to T6189: Ponder file upload permissions are too restrictive.

I would vote to unbeta Ponder after this fix. I can't believe I said that.

Sep 25 2014, 5:46 PM · Policy, Ponder
epriestley added a comment to T6189: Ponder file upload permissions are too restrictive.

Oh, haha, you're right. This should be a simple fix.

Sep 25 2014, 5:45 PM · Policy, Ponder
bluehawk added a comment to T6189: Ponder file upload permissions are too restrictive.

Crap. Since I also attached that file to this task, and you guys can view this task you can view the image.

Sep 25 2014, 5:38 PM · Policy, Ponder
chad added a comment to T6189: Ponder file upload permissions are too restrictive.

Click "Attached" on the File page.

Sep 25 2014, 5:17 PM · Policy, Ponder
bluehawk added a comment to T6189: Ponder file upload permissions are too restrictive.

Is there a way to view what objects a file is attached to?

Sep 25 2014, 5:04 PM · Policy, Ponder
chad added a comment to T6189: Ponder file upload permissions are too restrictive.

When I drag and drop and image in Ponder, I get the following when I click on the File's Policy:

Sep 25 2014, 4:55 PM · Policy, Ponder
bluehawk added a comment to T6189: Ponder file upload permissions are too restrictive.

Problem still occurs when updated to latest master.

Sep 25 2014, 4:43 PM · Policy, Ponder
bluehawk added a comment to T6189: Ponder file upload permissions are too restrictive.

Just kidding, got it to work on my test install

Sep 25 2014, 4:34 PM · Policy, Ponder
bluehawk added a comment to T6189: Ponder file upload permissions are too restrictive.

I actually can't seem to get it to reproduce at all. I can only figure that one of our developers restricted the permissions of the file he uploaded and then suffered amnesia about it.

Sep 25 2014, 4:30 PM · Policy, Ponder
epriestley added a comment to T6189: Ponder file upload permissions are too restrictive.

(There may be a narrow issue here like "images in the main text of a ponder answer don't get the right permissions".)

Sep 25 2014, 4:24 PM · Policy, Ponder
epriestley added a comment to T6189: Ponder file upload permissions are too restrictive.

I can see it.

Sep 25 2014, 4:24 PM · Policy, Ponder
bluehawk added a comment to T6189: Ponder file upload permissions are too restrictive.

Hmm, I might be wrong. Can anyone else see the image in the ponder question?

Sep 25 2014, 4:21 PM · Policy, Ponder
bluehawk created T6189: Ponder file upload permissions are too restrictive.
Sep 25 2014, 4:19 PM · Policy, Ponder
epriestley added a comment to T6188: User should receive a nicer exception when selecting an invalid application policy like "Can Use Application: No One".

We use the same policy control everywhere, but some policies aren't meaningful in some contexts. We could do a better job about hiding them, although that would also create some confusion ("why can't I select 'no one' in this dropdown?"). Since it's fairly obvious why "no one" doesn't work with the current workflow once you save, I don't think this is too bad. It could be a bit cleaner, but the ideal version of this would look roughly the same ("no one" present, tells you why you can't use it when selected, just looks less exception-ey).

Sep 25 2014, 4:00 PM · Policy
epriestley triaged T6188: User should receive a nicer exception when selecting an invalid application policy like "Can Use Application: No One" as Wishlist priority.
Sep 25 2014, 3:58 PM · Policy

Sep 24 2014

epriestley merged T6178: Add "Author" as a parameter for custom policies into T5681: Allow applications to provide custom policy rules.
Sep 24 2014, 8:33 PM · FreeBSD, Policy
epriestley merged task T6178: Add "Author" as a parameter for custom policies into T5681: Allow applications to provide custom policy rules.
Sep 24 2014, 8:33 PM · Policy
qgil created T6178: Add "Author" as a parameter for custom policies.
Sep 24 2014, 7:42 PM · Policy

Sep 18 2014

btrahan closed T5603: Implement a separate "Can Leave Project" policy as Resolved.

Closed by commit rP3238f1e09142.

Sep 18 2014, 5:56 PM · Projects, Policy

Sep 17 2014

btrahan added a revision to T5603: Implement a separate "Can Leave Project" policy: Restricted Differential Revision.
Sep 17 2014, 8:27 PM · Projects, Policy

Sep 16 2014

chad triaged T6104: "Task Restricted Task" as Low priority.
Sep 16 2014, 10:31 PM · Support Impact, Policy

Sep 14 2014

epriestley assigned T5603: Implement a separate "Can Leave Project" policy to btrahan.
Sep 14 2014, 6:51 PM · Projects, Policy
epriestley added a comment to T5603: Implement a separate "Can Leave Project" policy.
  • Add a new application capability, like "Can Lock Projects", to the Projects application, with a default setting of "administrators".
  • Add a checkbox on the edit screen like [ ] Lock Project: Prevent members from leaving this project.. Require "Can Lock Projects" to adjust this. Use explainApplicationCapability() to render a link explaining why the user can or can not lock the project.
  • When a project is locked, require CAN_EDIT to leave it.
Sep 14 2014, 6:50 PM · Projects, Policy
epriestley added a subtask for T4411: Adding a CC to a Maniphest Task should give View rights for that user: T5604: Properly integrate Maniphest with Subscribers.
Sep 14 2014, 5:34 PM · Wikimedia, Policy

Sep 9 2014

qgil moved T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects from Potential blockers to Important on the Wikimedia board.
Sep 9 2014, 8:43 AM · Spaces, Wikimedia, Policy

Sep 5 2014

chad updated the task description for T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.
Sep 5 2014, 8:12 PM · Spaces, Wikimedia, Policy

Aug 29 2014

epriestley updated subscribers of T4830: Applications with Public permissions requiring users to login.

I also have learned that the custom avatars in Recent Activity will not be shown to anonymous users either

Aug 29 2014, 9:52 PM · Facts, Policy, People
qgil added a comment to T4830: Applications with Public permissions requiring users to login.

... and now we have a real use case where the lack of public user profiles affects us.

Aug 29 2014, 8:45 PM · Facts, Policy, People

Aug 20 2014

btrahan closed T5922: File info page doesn't support public users, a subtask of T4830: Applications with Public permissions requiring users to login, as Resolved.
Aug 20 2014, 8:15 PM · Facts, Policy, People
qgil added a subtask for T4830: Applications with Public permissions requiring users to login: T5922: File info page doesn't support public users.
Aug 20 2014, 3:41 PM · Facts, Policy, People