Page MenuHomePhabricator
Differential D21022

Remove all readers and writers of "accountID" on "ExternalAccount"
ClosedPublic
Actions

Authored by epriestley on Feb 23 2020, 1:20 AM.
Tags
None
Referenced Files
F18469755: D21022.id50070.diff
Tue, Sep 2, 5:07 PM
F18469356: D21022.id50083.diff
Tue, Sep 2, 4:38 PM
F18468985: D21022.id50070.diff
Tue, Sep 2, 4:10 PM
F18467857: D21022.id50070.diff
Tue, Sep 2, 1:42 PM
F18466900: D21022.diff
Tue, Sep 2, 11:07 AM
F18466385: D21022.id50083.diff
Tue, Sep 2, 9:41 AM
F18466309: D21022.id.diff
Tue, Sep 2, 9:28 AM
F18465229: D21022.diff
Tue, Sep 2, 6:45 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits
rP802b5aca05cc: Remove all readers and writers of "accountID" on "ExternalAccount"
Summary

Depends on D21019. Ref T13493. There are no more barriers to removing readers and writers of "accountID"; the new "ExternalAccountIdentity" table can replace it completely.

Test Plan

Linked and unlinked OAuth accounts, logged in with OAuth accounts, tried to double-link OAuth accounts, grepped for affected symbols.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
adapter/
2 lines
provider/
14 lines
query/
86 lines

Diff 50083

View Options

src/applications/auth/adapter/PhutilOAuth1AuthAdapter.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProvider.php

Loading...
View Options

src/applications/auth/query/PhabricatorExternalAccountQuery.php

Loading...
Phabricator · Built by Phacility