Remove all readers and writers of "accountID" on "ExternalAccount"
ClosedPublic
Actions

Authored by epriestley on Feb 23 2020, 1:20 AM.

Details

Reviewers: None
Maniphest Tasks: T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits: rP802b5aca05cc: Remove all readers and writers of "accountID" on "ExternalAccount"

Summary

Depends on D21019. Ref T13493. There are no more barriers to removing readers and writers of "accountID"; the new "ExternalAccountIdentity" table can replace it completely.

Test Plan

Linked and unlinked OAuth accounts, logged in with OAuth accounts, tried to double-link OAuth accounts, grepped for affected symbols.

Diff Detail

Repository

rP Phabricator

Branch

auth12

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/auth/provider/PhabricatorAuthProvider.php:373	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 23892
Build 32878: Run Core Tests
Build 32877: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 23 2020, 1:20 AM

Harbormaster completed remote builds in B23892: Diff 50070.Feb 23 2020, 1:21 AM

epriestley requested review of this revision.Feb 23 2020, 1:21 AM

epriestley added a child revision: D21023: Read both older "key" and newer "accountId" identifiers from JIRA during authentication.Feb 23 2020, 1:36 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2020, 1:49 AM

Closed by commit rP802b5aca05cc: Remove all readers and writers of "accountID" on "ExternalAccount" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP802b5aca05cc: Remove all readers and writers of "accountID" on "ExternalAccount".

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

adapter/

PhutilOAuth1AuthAdapter.php

2 lines

provider/

PhabricatorAuthProvider.php

14 lines

query/

PhabricatorExternalAccountQuery.php

86 lines

Diff 50070

View Options

src/applications/auth/adapter/PhutilOAuth1AuthAdapter.php

View Options

src/applications/auth/provider/PhabricatorAuthProvider.php

View Options

src/applications/auth/query/PhabricatorExternalAccountQuery.php

Remove all readers and writers of "accountID" on "ExternalAccount"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50070

src/applications/auth/adapter/PhutilOAuth1AuthAdapter.php

src/applications/auth/provider/PhabricatorAuthProvider.php

src/applications/auth/query/PhabricatorExternalAccountQuery.php

Remove all readers and writers of "accountID" on "ExternalAccount"
ClosedPublic
Actions

Revision Contents
Changeset List