Page MenuHomePhabricator
Differential D21015

Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible
ClosedPublic
Actions

Authored by epriestley on Feb 22 2020, 3:19 AM.
Tags
None
Referenced Files
F15419166: D21015.id50078.diff
Fri, Mar 21, 4:09 AM
F15418962: D21015.id50078.diff
Fri, Mar 21, 2:44 AM
F15415167: D21015.diff
Thu, Mar 20, 4:32 AM
F15411645: D21015.id.diff
Wed, Mar 19, 9:30 AM
F15411644: D21015.diff
Wed, Mar 19, 9:30 AM
F15399472: D21015.diff
Mon, Mar 17, 4:43 AM
F15395558: D21015.id50078.diff
Sun, Mar 16, 8:01 AM
F15394077: D21015.id.diff
Sat, Mar 15, 11:19 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits
rP0872051bfa28: Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all…
Summary

Depends on D21014. Ref T13493. Make these objects all use destructible interfaces and destroy sub-objects appropriately.

Test Plan
  • Used bin/remove destroy --trace ... to destroy a provider, a user, and an external account.
  • Observed destruction of sub-objects, including external account identifiers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 50078

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthProviderConfig.php

Loading...
View Options

src/applications/people/storage/PhabricatorExternalAccount.php

Loading...
View Options

src/applications/people/storage/PhabricatorExternalAccountIdentifier.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility