Page MenuHomePhabricator

Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible
ClosedPublic

Authored by epriestley on Feb 22 2020, 3:19 AM.
Tags
None
Referenced Files
F19088199: D21015.diff
Wed, Dec 3, 3:21 AM
F18814900: D21015.diff
Oct 21 2025, 12:05 AM
F18740804: D21015.id50060.diff
Oct 2 2025, 5:55 AM
F18709028: D21015.id.diff
Sep 28 2025, 11:36 PM
F18698530: D21015.diff
Sep 27 2025, 11:28 AM
F18695537: D21015.diff
Sep 27 2025, 5:49 AM
F18687257: D21015.id50078.diff
Sep 26 2025, 2:14 PM
F18674591: D21015.diff
Sep 25 2025, 4:02 PM
Subscribers
None

Details

Summary

Depends on D21014. Ref T13493. Make these objects all use destructible interfaces and destroy sub-objects appropriately.

Test Plan
  • Used bin/remove destroy --trace ... to destroy a provider, a user, and an external account.
  • Observed destruction of sub-objects, including external account identifiers.

Diff Detail

Repository
rP Phabricator
Branch
auth7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23884
Build 32864: Run Core Tests
Build 32863: arc lint + arc unit