Page MenuHomePhabricator

Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible
ClosedPublic

Authored by epriestley on Feb 22 2020, 3:19 AM.

Details

Summary

Depends on D21014. Ref T13493. Make these objects all use destructible interfaces and destroy sub-objects appropriately.

Test Plan
  • Used bin/remove destroy --trace ... to destroy a provider, a user, and an external account.
  • Observed destruction of sub-objects, including external account identifiers.

Diff Detail

Repository
rP Phabricator
Branch
auth7
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 23884
Build 32864: Run Core Tests
Build 32863: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 22 2020, 3:19 AM
epriestley requested review of this revision.Feb 22 2020, 3:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2020, 1:46 AM
This revision was automatically updated to reflect the committed changes.