Page MenuHomePhabricator
Differential D21022

Remove all readers and writers of "accountID" on "ExternalAccount"
ClosedPublic
Actions

Authored by epriestley on Feb 23 2020, 1:20 AM.
Tags
None
Referenced Files
F19515210: D21022.diff
Wed, Jan 14, 9:13 AM
F19514248: D21022.id50070.diff
Tue, Jan 13, 11:54 PM
F19004799: D21022.id.diff
Nov 21 2025, 12:26 PM
F19000065: D21022.diff
Nov 20 2025, 10:38 PM
F18889012: D21022.id50083.diff
Nov 7 2025, 7:59 AM
F18888736: D21022.diff
Nov 7 2025, 7:39 AM
F18862225: D21022.id50070.diff
Nov 2 2025, 6:23 PM
F18814908: D21022.diff
Oct 21 2025, 12:06 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits
rP802b5aca05cc: Remove all readers and writers of "accountID" on "ExternalAccount"
Summary

Depends on D21019. Ref T13493. There are no more barriers to removing readers and writers of "accountID"; the new "ExternalAccountIdentity" table can replace it completely.

Test Plan

Linked and unlinked OAuth accounts, logged in with OAuth accounts, tried to double-link OAuth accounts, grepped for affected symbols.

Diff Detail

Repository
rP Phabricator
Branch
auth12
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/auth/provider/PhabricatorAuthProvider.php:373XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 23892
Build 32878: Run Core Tests
Build 32877: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
adapter/
2 lines
provider/
14 lines
query/
86 lines

Diff 50070

View Options

src/applications/auth/adapter/PhutilOAuth1AuthAdapter.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProvider.php

Loading...
View Options

src/applications/auth/query/PhabricatorExternalAccountQuery.php

Loading...
Phabricator · Built by Phacility