Paths

Table of Contentst

Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible
ClosedPublic
Actions

Authored by epriestley on Feb 22 2020, 3:19 AM.

Details

Reviewers: None
Maniphest Tasks: T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits: rP0872051bfa28: Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all…

Summary

Depends on D21014. Ref T13493. Make these objects all use destructible interfaces and destroy sub-objects appropriately.

Test Plan

Used bin/remove destroy --trace ... to destroy a provider, a user, and an external account.
Observed destruction of sub-objects, including external account identifiers.

Diff Detail

Repository

rP Phabricator

Branch

auth7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23884
Build 32864: Run Core Tests
Build 32863: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 22 2020, 3:19 AM

Harbormaster completed remote builds in B23884: Diff 50060.Feb 22 2020, 3:20 AM

epriestley requested review of this revision.Feb 22 2020, 3:20 AM

epriestley added a child revision: D21016: Write ExternalAccountIdentifiers when interacting with external authentication providers.Feb 22 2020, 4:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2020, 1:46 AM

Closed by commit rP0872051bfa28: Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0872051bfa28: Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all….

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

auth/

storage/

PhabricatorAuthProviderConfig.php

32 lines

people/

storage/

PhabricatorExternalAccount.php

27 lines

PhabricatorExternalAccountIdentifier.php

13 lines

PhabricatorUser.php

12 lines

infrastructure/

query/

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

4 lines

Diff 50060

View Options

src/__phutil_library_map__.php

View Options

src/applications/auth/storage/PhabricatorAuthProviderConfig.php

View Options

src/applications/people/storage/PhabricatorExternalAccount.php

View Options

src/applications/people/storage/PhabricatorExternalAccountIdentifier.php

View Options

src/applications/people/storage/PhabricatorUser.php

View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all DestructibleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50060

src/__phutil_library_map__.php

src/applications/auth/storage/PhabricatorAuthProviderConfig.php

src/applications/people/storage/PhabricatorExternalAccount.php

src/applications/people/storage/PhabricatorExternalAccountIdentifier.php

src/applications/people/storage/PhabricatorUser.php

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible
ClosedPublic
Actions

Revision Contents
Changeset List