Page MenuHomePhabricator
Differential D21015

Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible
ClosedPublic
Actions

Authored by epriestley on Feb 22 2020, 3:19 AM.
Tags
None
Referenced Files
F15513881: D21015.diff
Thu, Apr 17, 10:21 PM
F15505387: D21015.id.diff
Tue, Apr 15, 2:49 AM
F15473824: D21015.id50060.diff
Sun, Apr 6, 1:55 AM
F15470610: D21015.id.diff
Fri, Apr 4, 11:41 PM
F15470570: D21015.diff
Fri, Apr 4, 11:28 PM
F15467718: D21015.id50078.diff
Thu, Apr 3, 5:33 PM
F15452254: D21015.id50078.diff
Sat, Mar 29, 3:22 AM
F15442230: D21015.id50078.diff
Wed, Mar 26, 10:13 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits
rP0872051bfa28: Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all…
Summary

Depends on D21014. Ref T13493. Make these objects all use destructible interfaces and destroy sub-objects appropriately.

Test Plan
  • Used bin/remove destroy --trace ... to destroy a provider, a user, and an external account.
  • Observed destruction of sub-objects, including external account identifiers.

Diff Detail

Repository
rP Phabricator
Branch
auth7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23884
Build 32864: Run Core Tests
Build 32863: arc lint + arc unit

Revision Contents
Changeset List

Diff 50060

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthProviderConfig.php

Loading...
View Options

src/applications/people/storage/PhabricatorExternalAccount.php

Loading...
View Options

src/applications/people/storage/PhabricatorExternalAccountIdentifier.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility