Page MenuHomePhabricator
Differential D21015

Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible
ClosedPublic
Actions

Authored by epriestley on Feb 22 2020, 3:19 AM.
Tags
None
Referenced Files
F13206250: D21015.id.diff
Wed, May 15, 6:33 AM
F13206222: D21015.id50060.diff
Wed, May 15, 6:15 AM
F13206095: D21015.id50078.diff
Wed, May 15, 5:07 AM
F13197191: D21015.diff
Sun, May 12, 11:53 PM
F13183350: D21015.diff
Fri, May 10, 8:30 AM
Unknown Object (File)
Sat, May 4, 2:14 PM
Unknown Object (File)
Fri, May 3, 9:56 AM
Unknown Object (File)
Mon, Apr 29, 7:29 AM
View All 92 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13493: JIRA API has changed identifiers from "key" to "accountId"
Commits
rP0872051bfa28: Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all…
Summary

Depends on D21014. Ref T13493. Make these objects all use destructible interfaces and destroy sub-objects appropriately.

Test Plan
  • Used bin/remove destroy --trace ... to destroy a provider, a user, and an external account.
  • Observed destruction of sub-objects, including external account identifiers.

Diff Detail

Repository
rP Phabricator
Branch
auth7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23884
Build 32864: Run Core Tests
Build 32863: arc lint + arc unit

Revision Contents
Changeset List

Diff 50060

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthProviderConfig.php

Loading...
View Options

src/applications/people/storage/PhabricatorExternalAccount.php

Loading...
View Options

src/applications/people/storage/PhabricatorExternalAccountIdentifier.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility