Page MenuHomePhabricator

Record account recovery email links in the user activity log and make the mail message reference the log
ClosedPublic

Authored by epriestley on Jul 19 2019, 10:05 PM.
Tags
None
Referenced Files
F13225908: D20673.diff
Sun, May 19, 6:12 PM
F13200938: D20673.diff
Tue, May 14, 5:52 AM
F13200174: D20673.diff
Mon, May 13, 10:38 PM
F13192596: D20673.id.diff
Sun, May 12, 8:55 AM
F13192567: D20673.id49300.diff
Sun, May 12, 8:38 AM
F13182430: D20673.diff
Thu, May 9, 11:28 PM
Unknown Object (File)
Mon, May 6, 2:42 AM
Unknown Object (File)
Thu, May 2, 2:42 PM
Subscribers
None

Details

Summary

Depends on D20672. Ref T13343. When a user requests an account access link via email:

  • log it in the activity log; and
  • reference the log in the mail.

This makes it easier to ban users misusing the feature, provided they're coming from a single remote address, and takes a few steps down the pathway toward a button in the mail that users can click to report the action, suspend account recovery for their account, etc.

Test Plan
  • Requested an email recovery link.
  • Saw request appear in the user activity log.
  • Saw a reference to the log entry in the mail footer.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable