Page MenuHomePhabricator

Record account recovery email links in the user activity log and make the mail message reference the log
ClosedPublic

Authored by epriestley on Jul 19 2019, 10:05 PM.
Tags
None
Referenced Files
F13050994: D20673.id49319.diff
Fri, Apr 19, 3:18 AM
F13050993: D20673.id49300.diff
Fri, Apr 19, 3:18 AM
F13050992: D20673.id.diff
Fri, Apr 19, 3:18 AM
Unknown Object (File)
Wed, Apr 17, 2:44 PM
Unknown Object (File)
Thu, Apr 11, 11:01 AM
Unknown Object (File)
Thu, Apr 11, 7:30 AM
Unknown Object (File)
Thu, Apr 11, 4:28 AM
Unknown Object (File)
Wed, Apr 10, 7:42 PM
Subscribers
None

Details

Summary

Depends on D20672. Ref T13343. When a user requests an account access link via email:

  • log it in the activity log; and
  • reference the log in the mail.

This makes it easier to ban users misusing the feature, provided they're coming from a single remote address, and takes a few steps down the pathway toward a button in the mail that users can click to report the action, suspend account recovery for their account, etc.

Test Plan
  • Requested an email recovery link.
  • Saw request appear in the user activity log.
  • Saw a reference to the log entry in the mail footer.

Diff Detail

Repository
rP Phabricator
Branch
elogin12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23167
Build 31823: Run Core Tests
Build 31822: arc lint + arc unit