Page MenuHomePhabricator

Record account recovery email links in the user activity log and make the mail message reference the log
ClosedPublic

Authored by epriestley on Jul 19 2019, 10:05 PM.
Tags
None
Referenced Files
F15558493: D20673.id49319.diff
Tue, Apr 29, 3:30 AM
F15556237: D20673.id.diff
Mon, Apr 28, 3:22 PM
F15550819: D20673.diff
Sun, Apr 27, 1:54 PM
F15485005: D20673.id49300.diff
Wed, Apr 9, 9:13 PM
F15462475: D20673.diff
Tue, Apr 1, 3:17 PM
F15454113: D20673.id49319.diff
Mar 29 2025, 4:24 PM
F15445248: D20673.diff
Mar 27 2025, 1:07 PM
F15431152: D20673.diff
Mar 24 2025, 10:48 AM
Subscribers
None

Details

Summary

Depends on D20672. Ref T13343. When a user requests an account access link via email:

  • log it in the activity log; and
  • reference the log in the mail.

This makes it easier to ban users misusing the feature, provided they're coming from a single remote address, and takes a few steps down the pathway toward a button in the mail that users can click to report the action, suspend account recovery for their account, etc.

Test Plan
  • Requested an email recovery link.
  • Saw request appear in the user activity log.
  • Saw a reference to the log entry in the mail footer.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable