Page MenuHomePhabricator

Modularize user activity log message types
ClosedPublic

Authored by epriestley on Jul 19 2019, 9:41 PM.
Tags
None
Referenced Files
F13145564: D20671.diff
Fri, May 3, 9:10 AM
F13137065: D20671.diff
Thu, May 2, 5:05 PM
Unknown Object (File)
Wed, May 1, 5:14 PM
Unknown Object (File)
Sun, Apr 28, 8:56 PM
Unknown Object (File)
Sun, Apr 28, 8:42 AM
Unknown Object (File)
Sun, Apr 28, 3:02 AM
Unknown Object (File)
Sat, Apr 27, 4:05 AM
Unknown Object (File)
Thu, Apr 25, 7:03 AM
Subscribers
None

Details

Summary

Depends on D20670. Ref T13343. The user activity message log types are currently hard-coded, so only upstream code can really use the log construct.

Under the theory that we're going to keep this log around going forward (just focus it a little bit), modularize things so the log is extensible.

Test Plan

Grepped for UserLog::, viewed activity logs in People and Settings.

(If I missed something here -- say, misspelled a constant -- the effect should just be that older logs don't get a human-readable label, so stakes are very low.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable