Page MenuHomePhabricator

Modularize user activity log message types
ClosedPublic

Authored by epriestley on Jul 19 2019, 9:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 2:17 AM
Unknown Object (File)
Sat, Nov 23, 12:46 AM
Unknown Object (File)
Wed, Nov 20, 12:37 PM
Unknown Object (File)
Tue, Nov 19, 8:01 AM
Unknown Object (File)
Sat, Nov 16, 7:41 AM
Unknown Object (File)
Sat, Nov 16, 6:32 AM
Unknown Object (File)
Wed, Nov 13, 4:28 AM
Unknown Object (File)
Tue, Nov 12, 7:04 AM
Subscribers
None

Details

Summary

Depends on D20670. Ref T13343. The user activity message log types are currently hard-coded, so only upstream code can really use the log construct.

Under the theory that we're going to keep this log around going forward (just focus it a little bit), modularize things so the log is extensible.

Test Plan

Grepped for UserLog::, viewed activity logs in People and Settings.

(If I missed something here -- say, misspelled a constant -- the effect should just be that older logs don't get a human-readable label, so stakes are very low.)

Diff Detail

Repository
rP Phabricator
Branch
elogin10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23165
Build 31819: Run Core Tests
Build 31818: arc lint + arc unit