Page MenuHomePhabricator

Modularize user activity log message types
ClosedPublic

Authored by epriestley on Jul 19 2019, 9:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 5:36 PM
Unknown Object (File)
Feb 3 2024, 10:58 PM
Unknown Object (File)
Feb 3 2024, 5:37 AM
Unknown Object (File)
Feb 1 2024, 5:34 AM
Unknown Object (File)
Jan 25 2024, 3:09 AM
Unknown Object (File)
Jan 18 2024, 4:16 AM
Unknown Object (File)
Jan 3 2024, 1:27 PM
Unknown Object (File)
Dec 28 2023, 1:13 PM
Subscribers
None

Details

Summary

Depends on D20670. Ref T13343. The user activity message log types are currently hard-coded, so only upstream code can really use the log construct.

Under the theory that we're going to keep this log around going forward (just focus it a little bit), modularize things so the log is extensible.

Test Plan

Grepped for UserLog::, viewed activity logs in People and Settings.

(If I missed something here -- say, misspelled a constant -- the effect should just be that older logs don't get a human-readable label, so stakes are very low.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable