Page MenuHomePhabricator

Modularize user activity log message types
ClosedPublic

Authored by epriestley on Jul 19 2019, 9:41 PM.
Tags
None
Referenced Files
F13209074: D20671.diff
Thu, May 16, 9:35 PM
F13198445: D20671.id49298.diff
Mon, May 13, 6:35 AM
F13188986: D20671.diff
Sat, May 11, 5:39 AM
F13188108: D20671.id.diff
Sat, May 11, 5:02 AM
F13181873: D20671.id49317.diff
Thu, May 9, 4:20 PM
Unknown Object (File)
Tue, May 7, 9:23 AM
Unknown Object (File)
Mon, May 6, 1:17 AM
Unknown Object (File)
Fri, May 3, 9:10 AM
Subscribers
None

Details

Summary

Depends on D20670. Ref T13343. The user activity message log types are currently hard-coded, so only upstream code can really use the log construct.

Under the theory that we're going to keep this log around going forward (just focus it a little bit), modularize things so the log is extensible.

Test Plan

Grepped for UserLog::, viewed activity logs in People and Settings.

(If I missed something here -- say, misspelled a constant -- the effect should just be that older logs don't get a human-readable label, so stakes are very low.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable