Page MenuHomePhabricator

Record account recovery email links in the user activity log and make the mail message reference the log
ClosedPublic

Authored by epriestley on Jul 19 2019, 10:05 PM.
Tags
None
Referenced Files
F15415341: D20673.id.diff
Thu, Mar 20, 5:29 AM
F15411153: D20673.diff
Wed, Mar 19, 8:52 AM
F15408255: D20673.diff
Tue, Mar 18, 9:56 PM
F15387514: D20673.diff
Sat, Mar 15, 2:31 AM
F15384754: D20673.diff
Fri, Mar 14, 8:43 PM
F15382231: D20673.diff
Fri, Mar 14, 11:23 AM
Unknown Object (File)
Feb 18 2025, 7:41 AM
Unknown Object (File)
Feb 15 2025, 10:21 AM
Subscribers
None

Details

Summary

Depends on D20672. Ref T13343. When a user requests an account access link via email:

  • log it in the activity log; and
  • reference the log in the mail.

This makes it easier to ban users misusing the feature, provided they're coming from a single remote address, and takes a few steps down the pathway toward a button in the mail that users can click to report the action, suspend account recovery for their account, etc.

Test Plan
  • Requested an email recovery link.
  • Saw request appear in the user activity log.
  • Saw a reference to the log entry in the mail footer.

Diff Detail

Repository
rP Phabricator
Branch
elogin12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23167
Build 31823: Run Core Tests
Build 31822: arc lint + arc unit