Page MenuHomePhabricator

Record account recovery email links in the user activity log and make the mail message reference the log
ClosedPublic

Authored by epriestley on Jul 19 2019, 10:05 PM.
Tags
None
Referenced Files
F19507176: D20673.diff
Fri, Jan 9, 6:10 PM
F19476620: D20673.diff
Wed, Jan 7, 7:23 PM
F19015035: D20673.id49300.diff
Nov 22 2025, 10:17 PM
F18878152: D20673.id.diff
Nov 6 2025, 3:25 PM
F18874290: D20673.diff
Nov 5 2025, 1:58 PM
F18857259: D20673.diff
Nov 1 2025, 2:16 PM
F18842002: D20673.id.diff
Oct 28 2025, 12:46 PM
F18805748: D20673.diff
Oct 18 2025, 4:20 PM
Subscribers
None

Details

Summary

Depends on D20672. Ref T13343. When a user requests an account access link via email:

  • log it in the activity log; and
  • reference the log in the mail.

This makes it easier to ban users misusing the feature, provided they're coming from a single remote address, and takes a few steps down the pathway toward a button in the mail that users can click to report the action, suspend account recovery for their account, etc.

Test Plan
  • Requested an email recovery link.
  • Saw request appear in the user activity log.
  • Saw a reference to the log entry in the mail footer.

Diff Detail

Repository
rP Phabricator
Branch
elogin12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23167
Build 31823: Run Core Tests
Build 31822: arc lint + arc unit