Page MenuHomePhabricator

Add a "sin()" function to charts
ClosedPublic

Authored by epriestley on Apr 17 2019, 2:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 10:50 PM
Unknown Object (File)
Sun, Feb 9, 7:40 AM
Unknown Object (File)
Sun, Feb 9, 7:40 AM
Unknown Object (File)
Sun, Feb 9, 7:40 AM
Unknown Object (File)
Tue, Jan 28, 5:10 AM
Unknown Object (File)
Tue, Jan 28, 5:10 AM
Unknown Object (File)
Tue, Jan 28, 5:10 AM
Unknown Object (File)
Sun, Jan 26, 6:33 AM
Subscribers

Details

Summary

Depends on D20443. Ref T13279. This is probably not terribly useful on its own, but is mostly a function which takes another function as an argument, and a step toward more useful functions like arithmetic and drawing a picture of an owl.

The only structural change here is that functions now read data parameters (domain, sample limit) using a more tailored "ChartDataQuery" instead of reading the actual axis. Mostly, I want a more cohesive representation of query state that can be easily passed to sub-functions, as here.

Test Plan

Screen Shot 2019-04-17 at 7.17.04 AM.png (1×1 px, 268 KB)

Diff Detail

Repository
rP Phabricator
Branch
chart8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22621
Build 31005: Run Core Tests
Build 31004: arc lint + arc unit