HomePhabricator

Add a "sin()" function to charts

Description

Add a "sin()" function to charts

Summary:
Depends on D20443. Ref T13279. This is probably not terribly useful on its own, but is mostly a function which takes another function as an argument, and a step toward more useful functions like arithmetic and drawing a picture of an owl.

The only structural change here is that functions now read data parameters (domain, sample limit) using a more tailored "ChartDataQuery" instead of reading the actual axis. Mostly, I want a more cohesive representation of query state that can be easily passed to sub-functions, as here.

Test Plan:

Screen Shot 2019-04-17 at 7.17.04 AM.png (1×1 px, 268 KB)

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: yelirekim

Maniphest Tasks: T13279

Differential Revision: https://secure.phabricator.com/D20444

Details

Provenance
epriestleyAuthored on Apr 17 2019, 2:17 PM
epriestleyPushed on Apr 18 2019, 8:19 PM
Reviewer
amckinley
Differential Revision
D20444: Add a "sin()" function to charts
Parents
rPc4e4448ee649: Add chart functions "x()" and "constant(3)"
Branches
Unknown
Tags
Unknown
Tasks
T13279: Build Charting for Facts
Build Status
Buildable 22673
Build 31070: Run Core Tests