Page MenuHomePhabricator

Add a "sin()" function to charts
ClosedPublic

Authored by epriestley on Apr 17 2019, 2:28 PM.
Tags
None
Referenced Files
F14121890: D20444.diff
Fri, Nov 29, 2:26 PM
F14118182: D20444.diff
Thu, Nov 28, 10:24 PM
Unknown Object (File)
Tue, Nov 26, 6:29 AM
Unknown Object (File)
Oct 27 2024, 7:41 AM
Unknown Object (File)
Oct 27 2024, 7:40 AM
Unknown Object (File)
Oct 27 2024, 7:20 AM
Unknown Object (File)
Oct 23 2024, 8:05 AM
Unknown Object (File)
Oct 18 2024, 6:16 AM
Subscribers

Details

Summary

Depends on D20443. Ref T13279. This is probably not terribly useful on its own, but is mostly a function which takes another function as an argument, and a step toward more useful functions like arithmetic and drawing a picture of an owl.

The only structural change here is that functions now read data parameters (domain, sample limit) using a more tailored "ChartDataQuery" instead of reading the actual axis. Mostly, I want a more cohesive representation of query state that can be easily passed to sub-functions, as here.

Test Plan

Screen Shot 2019-04-17 at 7.17.04 AM.png (1×1 px, 268 KB)

Diff Detail

Repository
rP Phabricator
Branch
chart8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22621
Build 31005: Run Core Tests
Build 31004: arc lint + arc unit