Page MenuHomePhabricator

Fetch chart data via async request and redraw charts when the window is resized
ClosedPublic

Authored by epriestley on Apr 17 2019, 2:31 AM.
Tags
None
Referenced Files
F15445206: D20440.id.diff
Thu, Mar 27, 12:51 PM
F15437075: D20440.diff
Tue, Mar 25, 5:22 PM
F15418099: D20440.diff
Thu, Mar 20, 8:52 PM
F15390804: D20440.id48795.diff
Sat, Mar 15, 6:44 AM
F15369846: D20440.id.diff
Wed, Mar 12, 8:24 AM
Unknown Object (File)
Feb 25 2025, 9:54 PM
Unknown Object (File)
Feb 24 2025, 7:29 PM
Unknown Object (File)
Feb 14 2025, 10:49 PM
Subscribers

Details

Summary

Depends on D20439. Ref T13279. Some day, charts will probably need to reload themselves or do a bunch of defer/request-shaping magic when they're on a dashboard with 900 other charts.

Give the controller separate "HTML placeholder" and "actual data" modes, and make the placeholder fetch the data in a separate request.

Then, make the chart redraw if you resize the window instead of staying at whatever size it started as.

Test Plan
  • Loaded a chart, saw it load data asynchronously.
  • Resized the window, saw the chart resize.

Diff Detail

Repository
rP Phabricator
Branch
chart4
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/fact/Chart.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed
Build Status
Buildable 22615
Build 30993: Run Core Tests
Build 30992: arc lint + arc unit