Page MenuHomePhabricator

Index and show Owners packages affected by Herald rules
ClosedPublic

Authored by epriestley on Apr 12 2019, 11:17 PM.
Tags
None
Referenced Files
F15474469: D20413.id.diff
Sun, Apr 6, 8:53 AM
F15471413: D20413.diff
Sat, Apr 5, 4:54 AM
F15470353: D20413.diff
Fri, Apr 4, 9:39 PM
F15457394: D20413.diff
Sun, Mar 30, 4:05 PM
F15412832: D20413.diff
Wed, Mar 19, 3:11 PM
F15407320: D20413.diff
Tue, Mar 18, 4:52 PM
F15388089: D20413.id48756.diff
Sat, Mar 15, 3:18 AM
Unknown Object (File)
Mar 3 2025, 12:03 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20412. See PHI1147.

  • Index the targets of "Add Reviewer", "Add Blocking Reviewer", "Add Auditor", "Add Subscriber", and "Remove Subscriber" Herald rules. My major goal is to get Owners packages. This will also hit projects/users, but we just don't read those edges (for now, at least).
  • Add a "Related Herald Rules" panel to Owners Package pages.
  • Add a migration to reindex Herald rules for the recent build plan stuff and this, now that such a migration is easy to write.
Test Plan

Ran migration, verified all rules reindexed.

Screen Shot 2019-04-12 at 4.13.15 PM.png (988×1 px, 232 KB)

Diff Detail

Repository
rP Phabricator
Branch
panel15
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22576
Build 30924: Run Core Tests
Build 30923: arc lint + arc unit