Details
- Reviewers
amckinley - Maniphest Tasks
- T10333: Add groups to workboard columns
- Commits
- rP2fdab434faf3: Implement "Group by Owner" on Workboards
Diff Detail
- Repository
- rP Phabricator
- Branch
- grip6
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 22268 Build 30453: Run Core Tests Build 30452: arc lint + arc unit
Event Timeline
- Typo correction.
I think the "Invalid Owner" case is likely very rare and having more information may be helpful in sorting it out, but there's no reason we couldn't do a single "invalid" bucket if that doesn't prove to be the case.
Other groupings like "priority" and "status" can end up with database values that have no display value, and I think the extra headers are probably helpful on the balance there, since sometimes they point directly at a corrective action (usually: reverting changes to configuration to put back priorities or statuses that you incorrectly got rid of). In these cases, at least, it seems more helpful to have an Unknown Status ("waylayed") header than an Invalid Status header, although admittedly it's less likely that anyone can take specific corrective action based on Unknown User ("PHID-USER-xyz") vs Invalid Owner.