Page MenuHomePhabricator

Add "assert_same_keys()" to "libphutil/"
ClosedPublic

Authored by epriestley on Mar 11 2019, 4:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 3:55 PM
Unknown Object (File)
Wed, Dec 18, 10:29 AM
Unknown Object (File)
Tue, Dec 17, 1:48 PM
Unknown Object (File)
Thu, Dec 12, 4:49 PM
Unknown Object (File)
Thu, Dec 12, 7:47 AM
Unknown Object (File)
Sat, Dec 7, 7:05 AM
Unknown Object (File)
Fri, Nov 29, 11:45 PM
Unknown Object (File)
Mon, Nov 25, 6:04 AM
Subscribers
None

Details

Summary

This makes an implementation a little cleaner in an upcoming workboards diff.

This is like array_keys($x) === array_keys($y), but we get a slightly more useful error message, and we don't care about order.

Test Plan

Added and ran unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/utils/utils.php
639

At some point, you just gotta throw in the towel and patch PHP to have list() and dictionary() to get some sanity back.

This revision is now accepted and ready to land.Mar 12 2019, 7:21 PM
This revision was automatically updated to reflect the committed changes.