Details
- Reviewers
amckinley - Maniphest Tasks
- T10578: Provide 'Sort by Points' option in workboards
- Commits
- rP03b7aca019d1: Implement "Sort by Points" on workboards
Diff Detail
- Repository
- rP Phabricator
- Branch
- grip12
- Lint
Lint Passed Severity Location Code Message Advice src/applications/project/order/PhabricatorProjectColumnPointsOrder.php:13 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 22254 Build 30433: Run Core Tests Build 30432: arc lint + arc unit
Event Timeline
This is a static sorting (like "By Date Created") where you can't change point values by dragging.
This is still a little more sensical than changing the date created though, isn't it?
| src/applications/project/order/PhabricatorProjectColumnCreatedOrder.php | ||
|---|---|---|
| 30–31 | This is going to conflict with D20281 but I'm sure you're on top of it. | |
| src/applications/project/order/PhabricatorProjectColumnPointsOrder.php | ||
| 13 | fa-ellipsis-h? fa-cubes? fa-exclamation-circle? fa-map-pin? I think I like fa-map-pin the best. This concludes today's bike shedding. | |
| 36 | Is this to call out, uh, "pointless" tasks to encourage someone to assign some points to them? | |
This is still a little more sensical than changing the date created though, isn't it?
Changing point values is definitely an actual operation. The major issue is that if you drag a card between other cards with values "10" and "39,000", what value do we assign? 10? 39,000? 11? 38,999? Average them to produce 19,505? All these answers are probably wrong under some schemes like "Always Assign Fibonacci Numbers as Costs" which is a Real Thing that has a wiki page:
https://en.wikipedia.org/wiki/Fibonacci_scale_(agile)
I think the only good answer is probably "Prompt the user to pick a number between 10 and 39,000 inclusive", but I think they probably might as well just click the edit icon to do that anyway. We could tweak this if we get a pile of feedback or something (or let you configure a discrete set of possible point values, then put headers on this view if you do) since there's no fundamental problem with the underlying operation.
| src/applications/project/order/PhabricatorProjectColumnCreatedOrder.php | ||
|---|---|---|
| 30–31 | Yeah, D20281 is way at the end of this sequence. | |
| src/applications/project/order/PhabricatorProjectColumnPointsOrder.php | ||
| 36 | Yeah, similar to how "Unowned" tasks are on top and "Needs Triage" is the highest priority. | |