Differential D20273

Allow MFA task edits to go through on workboards
ClosedPublic
Actions

Authored by epriestley on Mar 11 2019, 5:34 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13074: Plans: Workboard triggers, groups, and subproject columns

Commits

rP74de153e59be: Allow MFA task edits to go through on workboards

Summary

Depends on D20272. Ref T13074. When a task requires MFA to edit, you currently get a fatal. Provide a cancel URI so the prompt works and the edit can go through.

Test Plan

Locked a task, dragged it on a workboard.
Before: fatal trying to build an MFA gate.
After: got MFA gated, answered prompt, action went through.

Diff Detail

Repository

rP Phabricator

Branch

grip9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22251
Build 30427: Run Core Tests
Build 30426: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 11 2019, 5:34 AM

Harbormaster completed remote builds in B22251: Diff 48388.Mar 11 2019, 5:35 AM

epriestley requested review of this revision.Mar 11 2019, 5:35 AM

epriestley added a child revision: D20274: Provide better UI feedback about cards that can't be dragged or edited.Mar 11 2019, 6:01 AM

amckinley accepted this revision.Mar 12 2019, 8:05 PM

This revision is now accepted and ready to land.Mar 12 2019, 8:05 PM

Closed by commit rP74de153e59be: Allow MFA task edits to go through on workboards (authored by epriestley). · Explain WhyMar 12 2019, 8:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectMoveController.php

10 lines

Diff 48388

View Options

src/applications/project/controller/PhabricatorProjectMoveController.php

Allow MFA task edits to go through on workboardsClosedPublicActions