Page MenuHomePhabricator

Improve rendering of empty workboard columns in header views
ClosedPublic

Authored by epriestley on Mar 11 2019, 5:26 AM.
Tags
None
Referenced Files
F15463838: D20272.id48408.diff
Wed, Apr 2, 3:58 AM
F15413701: D20272.id.diff
Wed, Mar 19, 8:40 PM
F15382652: D20272.diff
Fri, Mar 14, 1:38 PM
Unknown Object (File)
Feb 10 2025, 1:28 PM
Unknown Object (File)
Feb 9 2025, 5:37 PM
Unknown Object (File)
Feb 9 2025, 7:23 AM
Unknown Object (File)
Feb 9 2025, 7:23 AM
Unknown Object (File)
Feb 9 2025, 7:23 AM
Subscribers
None

Details

Summary

Depends on D20271. Ref T10333. When a column is empty but a board is grouped (by priority, owner, etc) render the headers properly.

When a column has headers, don't apply the "empty" style even if it has no cards. This style just makes some empty space so you can drag-and-drop more easily, but headers do the same thing.

Test Plan

Screen Shot 2019-03-10 at 10.22.46 PM.png (464×681 px, 29 KB)

Diff Detail

Repository
rP Phabricator
Branch
grip8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22250
Build 30425: Run Core Tests
Build 30424: arc lint + arc unit