Page MenuHomePhabricator
Differential D20025

Add a "test message" action for contact numbers
ClosedPublic
Actions

Authored by epriestley on Jan 23 2019, 8:18 PM.
Tags
None
Referenced Files
F13313523: D20025.diff
Tue, Jun 11, 8:01 AM
F13305385: D20025.id47822.diff
Sat, Jun 8, 9:23 PM
F13300526: D20025.diff
Fri, Jun 7, 9:17 AM
F13295459: D20025.id47801.diff
Thu, Jun 6, 3:10 AM
F13291996: D20025.id47801.diff
Wed, Jun 5, 1:01 AM
F13290547: D20025.id47801.diff
Tue, Jun 4, 6:25 PM
F13262942: D20025.id47800.diff
Mon, May 27, 5:10 AM
F13262675: D20025.diff
Mon, May 27, 2:25 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPab2cbbd9f946: Add a "test message" action for contact numbers
Summary

Depends on D20024. See D20022. Put something in place temporarily until we build out validation at some point.

Test Plan

Sent myself a test message.

Diff Detail

Repository
rP Phabricator
Branch
mfa20
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21653
Build 29533: Run Core Tests
Build 29532: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 47799.Jan 23 2019, 8:18 PM
epriestley created this revision.
  • Wordsmithing.
Harbormaster completed remote builds in B21651: Diff 47798.Jan 23 2019, 8:21 PM
Harbormaster completed remote builds in B21652: Diff 47799.
epriestley requested review of this revision.Jan 23 2019, 8:21 PM
epriestley updated this revision to Diff 47800.Jan 23 2019, 8:21 PM
  • Don't force delivery (so the mail page will show delivery issues).
  • Don't mark the content as sensitive (it's not particularly secret).
Harbormaster completed remote builds in B21653: Diff 47800.Jan 23 2019, 8:23 PM
amckinley accepted this revision.Jan 23 2019, 8:26 PM
amckinley added inline comments.
src/applications/auth/action/PhabricatorAuthTestSMSAction.php
19

"textings"... or maybe this was supposed to be "testing texts"?

This revision is now accepted and ready to land.Jan 23 2019, 8:26 PM
epriestley updated this revision to Diff 47801.Jan 23 2019, 8:29 PM
  • Texting's
Harbormaster completed remote builds in B21654: Diff 47801.Jan 23 2019, 8:31 PM
epriestley added a child revision: D20026: Add a Duo API future.Jan 23 2019, 9:33 PM
Closed by commit rPab2cbbd9f946: Add a "test message" action for contact numbers (authored by epriestley). · Explain WhyJan 23 2019, 10:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47800

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/auth/action/PhabricatorAuthTestSMSAction.php

Loading...
View Options

src/applications/auth/application/PhabricatorAuthApplication.php

Loading...
View Options

src/applications/auth/controller/contact/PhabricatorAuthContactNumberTestController.php

Loading...
View Options

src/applications/auth/controller/contact/PhabricatorAuthContactNumberViewController.php

Loading...
View Options

src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php

Loading...
Phabricator · Built by Phacility