Improve UI for "wait" and "answered" MFA challenges
ClosedPublic
Actions

Authored by epriestley on Dec 18 2018, 10:19 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13222: 2018 Week 48-51 Bonus Content

Commits

rP1729e7b46792: Improve UI for "wait" and "answered" MFA challenges

Summary

Depends on D19906. Ref T13222. This isn't going to win any design awards, but make the "wait" and "answered" elements a little more clear.

Ideally, the icon parts could be animated Google Authenticator-style timers (but I think we'd need to draw them in a <canvas /> unless there's some clever trick that I don't know) or maybe we could just have the background be like a "water level" that empties out. Not sure I'm going to actually write the JS for either of those, but the UI at least looks a little more intentional.

Test Plan

Screen Shot 2018-12-18 at 2.13.03 PM.png (849×1 px, 139 KB)

Screen Shot 2018-12-18 at 2.12.51 PM.png (849×1 px, 116 KB)

Diff Detail

Repository

rP Phabricator

Branch

mfa25

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21377
Build 29105: Run Core Tests
Build 29104: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 18 2018, 10:19 PM

Harbormaster completed remote builds in B21377: Diff 47523.Dec 18 2018, 10:21 PM

epriestley requested review of this revision.Dec 18 2018, 10:21 PM

epriestley added a child revision: D19909: Remove the "willApplyTransactions()" hook from ApplicationTransactionEditor.Dec 18 2018, 10:34 PM

Ideally, the icon parts could be animated Google Authenticator-style timers...

Not to create more work for you since this looks fine, but how about something like this? https://codepen.io/carsy/pen/VvqJwm

This revision is now accepted and ready to land.Dec 18 2018, 11:24 PM

Ah, neat. I've been wary of SVG since rendering user-controlled SVG (T6445) is such a horrible minefield, but I expect charting to be SVG-based so we're going to have to cross that bridge eventually...

Closed by commit rP1729e7b46792: Improve UI for "wait" and "answered" MFA challenges (authored by epriestley). · Explain WhyDec 28 2018, 8:19 AM

This revision was automatically updated to reflect the committed changes.