Page MenuHomePhabricator

Improve UI for "wait" and "answered" MFA challenges
ClosedPublic

Authored by epriestley on Dec 18 2018, 10:19 PM.

Details

Summary

Depends on D19906. Ref T13222. This isn't going to win any design awards, but make the "wait" and "answered" elements a little more clear.

Ideally, the icon parts could be animated Google Authenticator-style timers (but I think we'd need to draw them in a <canvas /> unless there's some clever trick that I don't know) or maybe we could just have the background be like a "water level" that empties out. Not sure I'm going to actually write the JS for either of those, but the UI at least looks a little more intentional.

Test Plan

Diff Detail

Repository
rP Phabricator
Branch
mfa25
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 21377
Build 29105: Run Core Tests
Build 29104: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 18 2018, 10:19 PM
epriestley requested review of this revision.Dec 18 2018, 10:21 PM
amckinley accepted this revision.Dec 18 2018, 11:24 PM

Ideally, the icon parts could be animated Google Authenticator-style timers...

Not to create more work for you since this looks fine, but how about something like this? https://codepen.io/carsy/pen/VvqJwm

This revision is now accepted and ready to land.Dec 18 2018, 11:24 PM

Ah, neat. I've been wary of SVG since rendering user-controlled SVG (T6445) is such a horrible minefield, but I expect charting to be SVG-based so we're going to have to cross that bridge eventually...

This revision was automatically updated to reflect the committed changes.