Page MenuHomePhabricator

Fix a double-prompt for MFA when recovering a password account
ClosedPublic

Authored by epriestley on Dec 18 2018, 8:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 6, 4:06 PM
Unknown Object (File)
Wed, Nov 27, 7:04 AM
Unknown Object (File)
Nov 23 2024, 5:43 AM
Unknown Object (File)
Nov 18 2024, 9:29 PM
Unknown Object (File)
Nov 15 2024, 12:53 PM
Unknown Object (File)
Nov 11 2024, 10:55 AM
Unknown Object (File)
Nov 6 2024, 5:59 PM
Unknown Object (File)
Oct 16 2024, 2:15 AM
Subscribers
None

Details

Summary

Depends on D19905. Ref T13222. In D19843, I refactored this stuff but $jump_into_hisec was dropped.

This is a hint to keep the upgraded session in hisec mode, which we need to do a password reset when using a recovery link. Without it, we double prompt you for MFA: first to upgrade to a full session, then to change your password.

Pass this into the engine properly to avoid the double-prompt.

Test Plan
  • Used bin/auth recover to get a partial session with MFA enabled and a password provider.
  • Before: double MFA prompt.
  • After: session stays upgraded when it becomes full, no second prompt.

Diff Detail

Repository
rP Phabricator
Branch
mfa24
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21371
Build 29095: Run Core Tests
Build 29094: arc lint + arc unit