Page MenuHomePhabricator

Fix a double-prompt for MFA when recovering a password account
ClosedPublic

Authored by epriestley on Dec 18 2018, 8:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 5:43 PM
Unknown Object (File)
Thu, Mar 21, 11:56 AM
Unknown Object (File)
Thu, Mar 21, 11:56 AM
Unknown Object (File)
Sat, Mar 16, 4:21 AM
Unknown Object (File)
Feb 8 2024, 10:41 PM
Unknown Object (File)
Feb 3 2024, 8:25 PM
Unknown Object (File)
Dec 27 2023, 12:59 PM
Unknown Object (File)
Dec 22 2023, 7:27 PM
Subscribers
None

Details

Summary

Depends on D19905. Ref T13222. In D19843, I refactored this stuff but $jump_into_hisec was dropped.

This is a hint to keep the upgraded session in hisec mode, which we need to do a password reset when using a recovery link. Without it, we double prompt you for MFA: first to upgrade to a full session, then to change your password.

Pass this into the engine properly to avoid the double-prompt.

Test Plan
  • Used bin/auth recover to get a partial session with MFA enabled and a password provider.
  • Before: double MFA prompt.
  • After: session stays upgraded when it becomes full, no second prompt.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable