Page MenuHomePhabricator

Fix a double-prompt for MFA when recovering a password account
ClosedPublic

Authored by epriestley on Dec 18 2018, 8:04 PM.
Tags
None
Referenced Files
F19096214: D19906.id.diff
Thu, Dec 4, 9:05 AM
F19089678: D19906.diff
Wed, Dec 3, 8:15 AM
F19080861: D19906.diff
Tue, Dec 2, 3:11 AM
F19072863: D19906.diff
Sun, Nov 30, 11:44 PM
F19072804: D19906.diff
Sun, Nov 30, 11:35 PM
F18856091: D19906.diff
Nov 1 2025, 7:56 AM
F18855291: D19906.id.diff
Nov 1 2025, 4:47 AM
F18744427: D19906.diff
Oct 3 2025, 2:57 AM
Subscribers
None

Details

Summary

Depends on D19905. Ref T13222. In D19843, I refactored this stuff but $jump_into_hisec was dropped.

This is a hint to keep the upgraded session in hisec mode, which we need to do a password reset when using a recovery link. Without it, we double prompt you for MFA: first to upgrade to a full session, then to change your password.

Pass this into the engine properly to avoid the double-prompt.

Test Plan
  • Used bin/auth recover to get a partial session with MFA enabled and a password provider.
  • Before: double MFA prompt.
  • After: session stays upgraded when it becomes full, no second prompt.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable