Differential D19901

Allow "MFA Required" objects to be edited without MFA if the edit is only creating inverse edges
ClosedPublic
Actions

Authored by epriestley on Dec 18 2018, 4:12 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13222: 2018 Week 48-51 Bonus Content

Commits

rPefb01bf34f60: Allow "MFA Required" objects to be edited without MFA if the edit is only…

Summary

Depends on D19900. Ref T13222. See PHI873. When an object requires MFA, we currently require MFA for every transaction.

This includes some ambiguous cases like "unsubscribe", but also includes "mention", which seems like clearly bad behavior.

Allow an "MFA" object to be the target of mentions, "edit child tasks", etc.

Test Plan

Mentioned an MFA object elsewhere (no MFA prompt).
Made an MFA object a subtask of a non-MFA object (no MFA prompt).
Tried to edit an MFA object normally (still got an MFA prompt).

Diff Detail

Repository

rP Phabricator

Branch

mfa19

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21365
Build 29084: Run Core Tests
Build 29083: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 18 2018, 4:12 PM

Harbormaster completed remote builds in B21365: Diff 47511.Dec 18 2018, 4:14 PM

epriestley requested review of this revision.Dec 18 2018, 4:14 PM

epriestley added a child revision: D19902: Allow tokens to be awarded to MFA-required objects.Dec 18 2018, 4:23 PM

amckinley accepted this revision.Dec 18 2018, 10:40 PM

This revision is now accepted and ready to land.Dec 18 2018, 10:40 PM

Closed by commit rPefb01bf34f60: Allow "MFA Required" objects to be edited without MFA if the edit is only… (authored by epriestley). · Explain WhyDec 28 2018, 8:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

7 lines

Diff 47511

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Allow "MFA Required" objects to be edited without MFA if the edit is only creating inverse edgesClosedPublicActions