Page MenuHomePhabricator
Differential D19901

Allow "MFA Required" objects to be edited without MFA if the edit is only creating inverse edges
ClosedPublic
Actions

Authored by epriestley on Dec 18 2018, 4:12 PM.
Tags
None
Referenced Files
F14413722: D19901.diff
Tue, Dec 24, 2:34 PM
Unknown Object (File)
Fri, Dec 20, 10:03 PM
Unknown Object (File)
Fri, Dec 20, 6:06 PM
Unknown Object (File)
Mon, Dec 16, 10:42 AM
Unknown Object (File)
Sun, Dec 15, 6:09 PM
Unknown Object (File)
Sat, Dec 14, 12:12 AM
Unknown Object (File)
Thu, Dec 12, 9:31 PM
Unknown Object (File)
Fri, Dec 6, 12:21 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rPefb01bf34f60: Allow "MFA Required" objects to be edited without MFA if the edit is only…
Summary

Depends on D19900. Ref T13222. See PHI873. When an object requires MFA, we currently require MFA for every transaction.

This includes some ambiguous cases like "unsubscribe", but also includes "mention", which seems like clearly bad behavior.

Allow an "MFA" object to be the target of mentions, "edit child tasks", etc.

Test Plan
  • Mentioned an MFA object elsewhere (no MFA prompt).
  • Made an MFA object a subtask of a non-MFA object (no MFA prompt).
  • Tried to edit an MFA object normally (still got an MFA prompt).

Diff Detail

Repository
rP Phabricator
Branch
mfa19
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21365
Build 29084: Run Core Tests
Build 29083: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editor/
7 lines

Diff 47511

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility