Page MenuHomePhabricator

Give PhabricatorAuthPassword a formal CAN_EDIT policy
ClosedPublic

Authored by epriestley on Aug 16 2018, 5:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 7:19 AM
Unknown Object (File)
Thu, Apr 25, 12:58 AM
Unknown Object (File)
Sun, Apr 14, 1:12 PM
Unknown Object (File)
Sun, Apr 14, 8:52 AM
Unknown Object (File)
Sun, Apr 14, 8:52 AM
Unknown Object (File)
Sun, Apr 14, 8:52 AM
Unknown Object (File)
Fri, Apr 12, 12:09 AM
Unknown Object (File)
Thu, Apr 11, 11:58 PM
Subscribers
None

Details

Summary

Depends on D19585. Ref T13164. This is a precursor for D19586, which causes Editors to start doing more explicit CAN_EDIT checks.

Passwords have an Editor, but don't actually define a CAN_EDIT capability. Define one (you can edit a password if you can edit the object the password is associated with).

(Today, this object is always a User -- this table just unified VCS passwords and Account passwords so they can be handled more consistently.)

Test Plan
  • With D19586, ran unit tests and got a pass.
  • Edited my own password.
  • Tried to edit another user's password and wasn't permitted to.

Diff Detail

Repository
rP Phabricator
Branch
uxaction8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20629
Build 28035: Run Core Tests
Build 28034: arc lint + arc unit