Page MenuHomePhabricator

Give PhabricatorAuthPassword a formal CAN_EDIT policy
ClosedPublic

Authored by epriestley on Aug 16 2018, 5:12 PM.
Tags
None
Referenced Files
F18253670: D19592.id.diff
Thu, Aug 21, 9:53 PM
F18225796: D19592.diff
Wed, Aug 20, 2:32 AM
F17816140: D19592.id.diff
Jul 25 2025, 10:34 PM
F17758760: D19592.diff
Jul 22 2025, 5:39 PM
F17627810: D19592.id.diff
Jul 10 2025, 6:50 AM
F17607130: D19592.diff
Jul 9 2025, 3:08 AM
Unknown Object (File)
Jul 1 2025, 10:08 PM
Unknown Object (File)
Jun 3 2025, 5:22 AM
Subscribers
None

Details

Summary

Depends on D19585. Ref T13164. This is a precursor for D19586, which causes Editors to start doing more explicit CAN_EDIT checks.

Passwords have an Editor, but don't actually define a CAN_EDIT capability. Define one (you can edit a password if you can edit the object the password is associated with).

(Today, this object is always a User -- this table just unified VCS passwords and Account passwords so they can be handled more consistently.)

Test Plan
  • With D19586, ran unit tests and got a pass.
  • Edited my own password.
  • Tried to edit another user's password and wasn't permitted to.

Diff Detail

Repository
rP Phabricator
Branch
uxaction8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20629
Build 28035: Run Core Tests
Build 28034: arc lint + arc unit