Page MenuHomePhabricator

Modularize Almanac property transactions
ClosedPublic

Authored by epriestley on Apr 10 2018, 6:03 PM.
Tags
None
Referenced Files
F15522929: D19334.diff
Sun, Apr 20, 10:31 PM
F15515285: D19334.diff
Fri, Apr 18, 9:14 AM
F15433274: D19334.id46244.diff
Mon, Mar 24, 10:24 PM
F15420537: D19334.id46244.diff
Mar 21 2025, 2:45 PM
F15418797: D19334.id46273.diff
Mar 21 2025, 1:32 AM
F15401053: D19334.diff
Mar 17 2025, 3:26 PM
F15400214: D19334.diff
Mar 17 2025, 10:21 AM
Unknown Object (File)
Feb 9 2025, 5:52 AM
Subscribers
None

Details

Summary

Depends on D19329. Ref T13120. Ref T12414. Recent changes have mostly modularized Almanac transactions, but the "property" transactions remained written in an older style with the logic on the Editor/Transaction classes.

This moves them to modern modular transactions. These end up being a little bit copy-pastey, but it doesn't feel too terribly bad.

Test Plan

Created, edited, and deleted properties on services, devices and bindings. Grepped for removed constants.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable