Page MenuHomePhabricator

Modularize transactions for Almanac Device
ClosedPublic

Authored by epriestley on Apr 10 2018, 3:43 PM.
Tags
None
Referenced Files
F13198941: D19329.diff
Mon, May 13, 10:30 AM
F13193652: D19329.id46270.diff
Sun, May 12, 4:26 PM
F13190381: D19329.id.diff
Sat, May 11, 10:22 AM
F13184555: D19329.id46236.diff
Fri, May 10, 8:21 PM
F13179441: D19329.diff
Wed, May 8, 9:12 PM
Unknown Object (File)
Sat, May 4, 6:45 PM
Unknown Object (File)
Wed, May 1, 12:06 AM
Unknown Object (File)
Sun, Apr 28, 1:07 PM
Subscribers
None

Details

Summary

Depends on D19328. Ref T13120. Ref T12414.

Prior work has left us with just a NAME transaction here, which is straightforward to modularize.

Test Plan
  • Created and renamed devices.
  • Tried to set no name, a bad name, a duplicate name (got errors).
  • Tried to create/rename into a namespace I could not edit (got an error).
  • Grepped for AlmanacDeviceTransaction::.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable