Page MenuHomePhabricator

Modularize transactions for Almanac Device
ClosedPublic

Authored by epriestley on Apr 10 2018, 3:43 PM.
Tags
None
Referenced Files
F13281339: D19329.diff
Sun, Jun 2, 10:34 AM
F13268600: D19329.diff
Wed, May 29, 5:12 AM
F13264076: D19329.diff
Mon, May 27, 2:17 PM
F13254146: D19329.diff
Sat, May 25, 3:12 AM
F13234154: D19329.diff
Tue, May 21, 3:09 AM
F13211615: D19329.diff
Fri, May 17, 5:55 AM
F13198941: D19329.diff
Mon, May 13, 10:30 AM
F13193652: D19329.id46270.diff
Sun, May 12, 4:26 PM
Subscribers
None

Details

Summary

Depends on D19328. Ref T13120. Ref T12414.

Prior work has left us with just a NAME transaction here, which is straightforward to modularize.

Test Plan
  • Created and renamed devices.
  • Tried to set no name, a bad name, a duplicate name (got errors).
  • Tried to create/rename into a namespace I could not edit (got an error).
  • Grepped for AlmanacDeviceTransaction::.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable