Differential D19336

Use a more conventional spelling of "Almanac" for "almanac.service.edit" class
ClosedPublic
Actions

Authored by epriestley on Apr 10 2018, 6:22 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T12414: Implement Almanac edit endpoints in Conduit
T13120: Plans: 2018 Week 15 Bonus Content

Commits

rP9022e140821e: Use a more conventional spelling of "Almanac" for "almanac.service.edit" class

Summary

Depends on D19335. Ref T13120. Ref T12414. There are many good ways to spell "almanac", but stick with convention here.

Test Plan

(O_O)

Diff Detail

Repository

rP Phabricator

Branch

almanac19

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20069
Build 27224: Run Core Tests
Build 27223: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 10 2018, 6:22 PM

Harbormaster completed remote builds in B20069: Diff 46246.Apr 10 2018, 6:23 PM

epriestley requested review of this revision.Apr 10 2018, 6:23 PM

amckinley accepted this revision.Apr 10 2018, 6:26 PM

This revision is now accepted and ready to land.Apr 10 2018, 6:26 PM

amckinley awarded a token.Apr 10 2018, 6:26 PM

epriestley added a child revision: D19337: Add "almanac.namespace.edit" and "almanac.namespace.search" API methods.Apr 10 2018, 6:41 PM

Closed by commit rP9022e140821e: Use a more conventional spelling of "Almanac" for "almanac.service.edit" class (authored by epriestley). · Explain WhyApr 11 2018, 5:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

almanac/

conduit/

AlamancServiceEditConduitAPIMethod.php

	AlmanacServiceEditConduitAPIMethod.php
	AlamancServiceEditConduitAPIMethod.php

2 lines

Diff 46246

View Options

src/__phutil_library_map__.php

View Options

src/applications/almanac/conduit/AlamancServiceEditConduitAPIMethod.php

View Options

src/applications/almanac/conduit/AlmanacServiceEditConduitAPIMethod.php

Use a more conventional spelling of "Almanac" for "almanac.service.edit" classClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46246

src/__phutil_library_map__.php

src/applications/almanac/conduit/AlamancServiceEditConduitAPIMethod.php

src/applications/almanac/conduit/AlmanacServiceEditConduitAPIMethod.php

Use a more conventional spelling of "Almanac" for "almanac.service.edit" class
ClosedPublic
Actions

Revision Contents
Changeset List