Page MenuHomePhabricator

Modularize Almanac property transactions
ClosedPublic

Authored by epriestley on Apr 10 2018, 6:03 PM.
Tags
None
Referenced Files
F19102264: D19334.id.diff
Dec 5 2025, 6:15 AM
F19096563: D19334.diff
Dec 4 2025, 10:07 AM
F18864890: D19334.diff
Nov 3 2025, 9:09 AM
F18857188: D19334.id46244.diff
Nov 1 2025, 1:46 PM
F18810167: D19334.id46273.diff
Oct 19 2025, 7:54 PM
F18806458: D19334.id46244.diff
Oct 18 2025, 7:37 PM
F18805968: D19334.id46273.diff
Oct 18 2025, 5:10 PM
F18798610: D19334.id46244.diff
Oct 17 2025, 7:14 AM
Subscribers
None

Details

Summary

Depends on D19329. Ref T13120. Ref T12414. Recent changes have mostly modularized Almanac transactions, but the "property" transactions remained written in an older style with the logic on the Editor/Transaction classes.

This moves them to modern modular transactions. These end up being a little bit copy-pastey, but it doesn't feel too terribly bad.

Test Plan

Created, edited, and deleted properties on services, devices and bindings. Grepped for removed constants.

Diff Detail

Repository
rP Phabricator
Branch
almanac17
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20067
Build 27220: Run Core Tests
Build 27219: arc lint + arc unit