Page MenuHomePhabricator

Modularize transactions for Almanac Device
ClosedPublic

Authored by epriestley on Apr 10 2018, 3:43 PM.
Tags
None
Referenced Files
F22584064: D19329.diff
Sun, Sep 27, 10:41 PM
Unknown Object (File)
Aug 2 2026, 12:10 PM
Unknown Object (File)
Jun 2 2026, 3:52 PM
Unknown Object (File)
May 29 2026, 5:06 PM
Unknown Object (File)
Apr 6 2026, 5:08 AM
Unknown Object (File)
Apr 3 2026, 5:58 AM
Unknown Object (File)
Feb 25 2026, 11:34 PM
Unknown Object (File)
Feb 25 2026, 1:42 PM
Subscribers
None

Details

Summary

Depends on D19328. Ref T13120. Ref T12414.

Prior work has left us with just a NAME transaction here, which is straightforward to modularize.

Test Plan
  • Created and renamed devices.
  • Tried to set no name, a bad name, a duplicate name (got errors).
  • Tried to create/rename into a namespace I could not edit (got an error).
  • Grepped for AlmanacDeviceTransaction::.

Diff Detail

Repository
rP Phabricator
Branch
almanac14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20060
Build 27210: Run Core Tests
Build 27209: arc lint + arc unit