Page MenuHomePhabricator

Modularize transactions for Almanac Device
ClosedPublic

Authored by epriestley on Apr 10 2018, 3:43 PM.
Tags
None
Referenced Files
F15523948: D19329.id46236.diff
Mon, Apr 21, 4:55 AM
F15515947: D19329.id.diff
Fri, Apr 18, 2:44 PM
F15515487: D19329.diff
Fri, Apr 18, 11:01 AM
F15512616: D19329.diff
Thu, Apr 17, 12:01 PM
F15483376: D19329.id46236.diff
Wed, Apr 9, 12:00 PM
F15441794: D19329.id46270.diff
Wed, Mar 26, 7:56 PM
F15416941: D19329.id46236.diff
Mar 20 2025, 2:27 PM
F15416021: D19329.id46270.diff
Mar 20 2025, 8:43 AM
Subscribers
None

Details

Summary

Depends on D19328. Ref T13120. Ref T12414.

Prior work has left us with just a NAME transaction here, which is straightforward to modularize.

Test Plan
  • Created and renamed devices.
  • Tried to set no name, a bad name, a duplicate name (got errors).
  • Tried to create/rename into a namespace I could not edit (got an error).
  • Grepped for AlmanacDeviceTransaction::.

Diff Detail

Repository
rP Phabricator
Branch
almanac14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20060
Build 27210: Run Core Tests
Build 27209: arc lint + arc unit