Page MenuHomePhabricator

Modularize transactions for Almanac Device
ClosedPublic

Authored by epriestley on Apr 10 2018, 3:43 PM.
Tags
None
Referenced Files
F15416021: D19329.id46270.diff
Thu, Mar 20, 8:43 AM
F15412678: D19329.id46270.diff
Wed, Mar 19, 2:19 PM
F15412149: D19329.id46236.diff
Wed, Mar 19, 11:31 AM
F15410315: D19329.id46236.diff
Wed, Mar 19, 7:03 AM
F15407224: D19329.id.diff
Tue, Mar 18, 4:25 PM
F15400765: D19329.diff
Mon, Mar 17, 1:55 PM
Unknown Object (File)
Mon, Mar 3, 8:07 AM
Unknown Object (File)
Feb 9 2025, 5:52 AM
Subscribers
None

Details

Summary

Depends on D19328. Ref T13120. Ref T12414.

Prior work has left us with just a NAME transaction here, which is straightforward to modularize.

Test Plan
  • Created and renamed devices.
  • Tried to set no name, a bad name, a duplicate name (got errors).
  • Tried to create/rename into a namespace I could not edit (got an error).
  • Grepped for AlmanacDeviceTransaction::.

Diff Detail

Repository
rP Phabricator
Branch
almanac14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20060
Build 27210: Run Core Tests
Build 27209: arc lint + arc unit