Page MenuHomePhabricator
Differential D19329

Modularize transactions for Almanac Device
ClosedPublic
Actions

Authored by epriestley on Apr 10 2018, 3:43 PM.
Tags
None
Referenced Files
F14402094: D19329.diff
Sun, Dec 22, 11:32 PM
Unknown Object (File)
Mon, Dec 9, 6:28 PM
Unknown Object (File)
Mon, Dec 9, 6:28 PM
Unknown Object (File)
Mon, Dec 9, 6:23 PM
Unknown Object (File)
Mon, Dec 9, 5:50 PM
Unknown Object (File)
Mon, Dec 9, 1:55 PM
Unknown Object (File)
Mon, Dec 2, 11:19 PM
Unknown Object (File)
Mon, Dec 2, 11:19 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T12414: Implement Almanac edit endpoints in Conduit
T13120: Plans: 2018 Week 15 Bonus Content
Commits
rP71c77fcc3a15: Modularize transactions for Almanac Device
Summary

Depends on D19328. Ref T13120. Ref T12414.

Prior work has left us with just a NAME transaction here, which is straightforward to modularize.

Test Plan
  • Created and renamed devices.
  • Tried to set no name, a bad name, a duplicate name (got errors).
  • Tried to create/rename into a namespace I could not edit (got an error).
  • Grepped for AlmanacDeviceTransaction::.

Diff Detail

Repository
rP Phabricator
Branch
almanac14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20060
Build 27210: Run Core Tests
Build 27209: arc lint + arc unit

Revision Contents
Changeset List

Diff 46236

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/almanac/editor/AlmanacDeviceEditEngine.php

Loading...
View Options

src/applications/almanac/editor/AlmanacDeviceEditor.php

Loading...
View Options

src/applications/almanac/storage/AlmanacDeviceTransaction.php

Loading...
View Options

src/applications/almanac/xaction/AlmanacDeviceNameTransaction.php

Loading...
View Options

src/applications/almanac/xaction/AlmanacDeviceTransactionType.php

Loading...
Phabricator · Built by Phacility