Paths

Table of Contentst

Differential D19325

Use Interface transactions, not Device transactions, to destroy Interfaces
ClosedPublic
Actions

Authored by epriestley on Apr 10 2018, 1:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 18, 12:20 AM

	Unknown Object (File)
	Tue, Dec 17, 3:50 AM

	Unknown Object (File)
	Mon, Dec 9, 6:28 PM

	Unknown Object (File)
	Mon, Dec 9, 6:28 PM

	Unknown Object (File)
	Mon, Dec 9, 6:28 PM

	Unknown Object (File)
	Mon, Dec 9, 6:23 PM

	Unknown Object (File)
	Mon, Dec 9, 5:50 PM

	Unknown Object (File)
	Sat, Dec 7, 4:43 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12414: Implement Almanac edit endpoints in Conduit
T13120: Plans: 2018 Week 15 Bonus Content

Commits

rPd240969e4705: Use Interface transactions, not Device transactions, to destroy Interfaces

Summary

Depends on D19324. Ref T13120. Ref T12414.

This moves "Destroy Interface" to use Interface transactions instead of Device transactions, so we can ultimately get rid of the complex and difficult-to-modernize AlmanacDeviceTransaction::TYPE_INTERFACE.

This transaction is a bit weird since it makes the interface delete itself, but this should work OK for now. At some point in the future I'd probably want to change this into more of a "disable" action, but I don't think we face any immediate peril by retaining this behavior for now.

Test Plan

Destroyed interfaces on devices using the web UI, saw them vanish.
Ran daemons, nothing fataled/exploded even though the transaction is weird and destroys the object it affects.

Diff Detail

Repository

Branch

almanac10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20058
Build 27206: Run Core Tests
Build 27205: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 10 2018, 1:28 PM

Harbormaster completed remote builds in B20055: Diff 46231.Apr 10 2018, 1:29 PM

epriestley requested review of this revision.Apr 10 2018, 1:29 PM

epriestley added a child revision: Restricted Differential Revision.Apr 10 2018, 1:38 PM

Only raise an error about deletion of in-use interfaces if there's actually a deleting transaction.

Harbormaster completed remote builds in B20058: Diff 46234.Apr 10 2018, 2:27 PM

epriestley added a child revision: D19328: Remove TYPE_INTERFACE transaction from Almanac Device.Apr 10 2018, 3:27 PM

amckinley accepted this revision.Apr 10 2018, 6:42 PM

This revision is now accepted and ready to land.Apr 10 2018, 6:42 PM

Closed by commit rPd240969e4705: Use Interface transactions, not Device transactions, to destroy Interfaces (authored by epriestley). · Explain WhyApr 11 2018, 5:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

almanac/

controller/

AlmanacInterfaceDeleteController.php

17 lines

xaction/

AlmanacInterfaceDestroyTransaction.php

32 lines

Diff 46234

src/__phutil_library_map__.php

Loading...

src/applications/almanac/controller/AlmanacInterfaceDeleteController.php

Loading...

src/applications/almanac/xaction/AlmanacInterfaceDestroyTransaction.php

Loading...