Page MenuHomePhabricator
Differential D19324

Edit Interfaces in Almanac with EditEngine
ClosedPublic
Actions

Authored by epriestley on Apr 10 2018, 1:17 PM.
Tags
None
Referenced Files
F15455539: D19324.diff
Sun, Mar 30, 3:01 AM
F15450573: D19324.id46230.diff
Fri, Mar 28, 4:30 PM
F15431987: D19324.diff
Mon, Mar 24, 3:42 PM
F15425855: D19324.id46230.diff
Sun, Mar 23, 6:27 AM
F15425130: D19324.diff
Sun, Mar 23, 2:36 AM
F15416613: D19324.id46230.diff
Thu, Mar 20, 12:27 PM
F15416578: D19324.diff
Thu, Mar 20, 12:15 PM
F15415656: D19324.id46265.diff
Thu, Mar 20, 7:12 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T12414: Implement Almanac edit endpoints in Conduit
T13120: Plans: 2018 Week 15 Bonus Content
Commits
rP6ccf35f9a256: Edit Interfaces in Almanac with EditEngine
Summary

Depends on D19323. Ref T13120. Ref T12414.

Move editing to modern stuff and fix some implementation errors from D19323 (mostly copy/paste stuff).

Test Plan
  • Created and edited interfaces.
  • Tried to create/edit an interface with a bogus/empty address/port, got errors.
  • Tried to create an interface on a bogus device, got an error.
  • Tried to create an interface on a device I could not edit, got an error.

Diff Detail

Repository
rP Phabricator
Branch
almanac9
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/almanac/editor/AlmanacInterfaceEditEngine.php:96XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 20054
Build 27200: Run Core Tests
Build 27199: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 10 2018, 1:17 PM
Harbormaster completed remote builds in B20054: Diff 46230.Apr 10 2018, 1:19 PM
epriestley requested review of this revision.Apr 10 2018, 1:19 PM
epriestley added a child revision: D19325: Use Interface transactions, not Device transactions, to destroy Interfaces.Apr 10 2018, 1:28 PM
amckinley accepted this revision.Apr 10 2018, 4:01 PM
amckinley added inline comments.
src/applications/almanac/editor/AlmanacInterfaceEditEngine.php
135

No need to cast to int here?

This revision is now accepted and ready to land.Apr 10 2018, 4:01 PM
epriestley added inline comments.Apr 10 2018, 4:51 PM
src/applications/almanac/editor/AlmanacInterfaceEditEngine.php
135

It ultimately gets forced into an int in the validation/transaction layers before being written anywhere.

Closed by commit rP6ccf35f9a256: Edit Interfaces in Almanac with EditEngine (authored by epriestley). · Explain WhyApr 11 2018, 5:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46230

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/almanac/controller/AlmanacInterfaceEditController.php

Loading...
View Options

src/applications/almanac/editor/AlmanacInterfaceEditEngine.php

Loading...
View Options

src/applications/almanac/xaction/AlmanacInterfaceAddressTransaction.php

Loading...
View Options

src/applications/almanac/xaction/AlmanacInterfaceDeviceTransaction.php

Loading...
View Options

src/applications/almanac/xaction/AlmanacInterfaceNetworkTransaction.php

Loading...
View Options

src/applications/almanac/xaction/AlmanacInterfacePortTransaction.php

Loading...
Phabricator · Built by Phacility