Page MenuHomePhabricator

As Harbormaster logs are processed, build a sparse map of byte offsets to line numbers
ClosedPublic

Authored by epriestley on Feb 23 2018, 7:12 PM.
Tags
None
Referenced Files
F15376766: D19139.diff
Thu, Mar 13, 5:25 AM
F15333650: D19139.id45845.diff
Sat, Mar 8, 3:45 AM
Unknown Object (File)
Wed, Feb 26, 1:02 AM
Unknown Object (File)
Feb 9 2025, 11:22 PM
Unknown Object (File)
Feb 9 2025, 5:32 AM
Unknown Object (File)
Feb 9 2025, 5:32 AM
Unknown Object (File)
Feb 9 2025, 5:32 AM
Unknown Object (File)
Jan 31 2025, 12:50 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19138. Ref T13088. When we want to read the last part of a logfile and show accurate line numbers, we need to be able to get from byte offsets to line numbers somehow.

Our fundamental unit must remain byte offsets, because a test can emit an arbitrarily long line, and we should accommodate it cleanly if a test emits 2GB of the letter "A".

To support going from byte offsets to line numbers, compute a map with periodic line markers throughout the offsets of the file. From here, we can figure out the line numbers for arbitrary positions in the file with only a constant amount of work.

Test Plan

Added unit tests; ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 7:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:57 AM
This revision was automatically updated to reflect the committed changes.